Repository navigation
Support shorthand ivar string interpolation - #22
Merged
Merged
Conversation
willcosgrove
force-pushed
the
embedded-variable
branch
from
January 7, 2026 21:43
3eb2cd5 to
56ad983
Compare
joeldrapper
approved these changes
Jan 8, 2026
joeldrapper
left a comment
Collaborator
There was a problem hiding this comment.
This looks great. We need to copy this into empirical too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently strict_ivars will produce incorrect code if it encounters an embedded variable node:
"#@foo"will become
Here's the situation where I noticed this was happening:

I added test cases, and a visitor for the EmbeddedVariableNode. I also added an early return if the variable is already in context. But it's not strictly required, it just seemed like a nice thing to do 🤷♂️