Fix PHPStan errors #20634
Merged
Fix PHPStan errors #20634
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mspirkov
commented
Oct 22, 2025
mspirkov
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
mspirkov
commented
Oct 22, 2025
| public static function validateData(array $data, $rules = []) | ||
| { | ||
| /** @var self $model */ | ||
| /** @var static $model */ |
mspirkov
commented
Oct 22, 2025
| public $link; | ||
| /** | ||
| * @var array|object the query associated with the junction table. Please call [[via()]] | ||
| * @var array|object|null the query associated with the junction table. Please call [[via()]] |
mspirkov
commented
Oct 22, 2025
| public $scale; | ||
| /** | ||
| * @var bool whether this column is a primary key | ||
| * @var bool|null whether this column is a primary key |
mspirkov
commented
Oct 22, 2025
| } | ||
|
|
||
| if ($this->expressionBuilders[$className] === __CLASS__) { | ||
| /** @phpstan-var $this&ExpressionBuilderInterface */ |
mspirkov
commented
Oct 22, 2025
| /** | ||
| * Returns whether the longest common prefix equals to the SQL code of the same length at the current offset. | ||
| * @param string[] $with strings to be tested. | ||
| * @param array $with strings to be tested. |
mspirkov
commented
Oct 22, 2025
| * @param ArrayExpression $expression | ||
| * @param mixed $value | ||
| * @return JsonExpression | ||
| * @return mixed |
terabytesoftw
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.