fix(bindings): clang-format + dart format the provenance accessors (unbreak main C++ & Dart CI) - #897
Merged
Merged
Conversation
#893 added the provenance element accessor to the C++ header but the new lines were not clang-formatted, so C++ Bindings CI on main fails the blocking clang-format check (-Wclang-format-violations, exit 123): cpp/include/pdf_oxide/pdf_oxide.hpp:908: error: code should be clang-formatted Ran clang-format --style=file:cpp/.clang-format; the only changes are `char *p` -> `char* p` and wrapping the take_string call. Verified with clang-format --dry-run --Werror (exit 0). Claude-Session: https://claude.ai/code/session_01VfT1dvLWaMNh4SpaXV8kcp Signed-off-by: Yury Fedoseev <yfedoseev@gmail.com>
#893 added the provenance element accessor to the Dart binding but the new lookupFunction line was not dart-formatted, so Dart Bindings CI on main fails the Format check (dart format --set-exit-if-changed, exit 1). Ran dart format; the only change is wrapping the elementGetProvenance lookupFunction call. Verified: dart format --output=none --set-exit-if-changed lib test example (0 changed, exit 0). Claude-Session: https://claude.ai/code/session_01VfT1dvLWaMNh4SpaXV8kcp Signed-off-by: Yury Fedoseev <yfedoseev@gmail.com>
yfedoseev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#893 landed the C++ and Dart provenance accessors without running their formatters, red-ing two binding CIs on main:
-Wclang-format-violations, exit 123,pdf_oxide.hpp:908)dart format --set-exit-if-changed(exit 1,pdf_oxide.dart)Both are formatting-only. Verified locally with the exact CI commands:
clang-format --dry-run --Werror --style=file:cpp/.clang-format→ exit 0dart format --output=none --set-exit-if-changed lib test example→ 0 changed, exit 0Neither check is in the 5 required set, which is why #893 merged despite them. No functional change.