fix: fetch ETH price from backend to avoid crashing at start#550
Draft
maximopalopoli wants to merge 2 commits into
Draft
fix: fetch ETH price from backend to avoid crashing at start#550maximopalopoli wants to merge 2 commits into
maximopalopoli wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fetches the eth price from the environment as a last option to avoid crashing on web deployment.
How to test
To test the feature, comment the current fetch_from_coingecko and fetch_from_cryptoprices implementations, returning an error instead. This way, on the backend start the price taken will be the one from the env.
To set the env variable, use
export ETH_PRICE_USD=3000.03.One place to check the price set is the bumping fee modal, so to check that the feat is running, submit a proof, go to the bumping fee modal, and see the prices. After setting the ETH_PRICE_USD variable as mentioned above and redeploying the server, you should see the new ETH price in the bumping options prices.