Merged
Conversation
| ::editing-reaction-template-errors | ||
| ::editing-reaction-template-json | ||
| ::csv-download-properties | ||
| ::statements-file-upload-xapi-version |
Member
There was a problem hiding this comment.
no db entry for event log?
| :statements.file-upload.title {:en-US "Upload Statements"} | ||
| :statements.file-upload.button {:en-US "Upload"} | ||
| :statements.file-upload.choose-file-button {:en-US "Choose file"} | ||
| :statements.file-upload.XAPI-version {:en-US "XAPI Version"} |
Member
There was a problem hiding this comment.
lets stick with the no-caps key precedent
| (when (seq events) | ||
| (let [cols [{:name "Event" | ||
| :selector #(str | ||
| ({"good" "✅" "bad" "❌"} (get % "code")) |
Member
There was a problem hiding this comment.
word i never thought to do that, i always just use images. As long as it has broad browser support im fine with it.
| "1.0.3"))) | ||
|
|
||
| (reg-sub | ||
| :statements-file-upload/file |
Member
There was a problem hiding this comment.
im not seeing all of these specced out in db
| {:fx [[:dispatch [:notification/notify true "File not valid JSON"]]] | ||
| :db (-> db | ||
| (update | ||
| ::db/statements-file-upload-event-log conj |
Member
There was a problem hiding this comment.
it kinda seems like you have an object format for the logs. I would recommend speccing that out as well in db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a widget that allows statement files to be uploaded