-
Notifications
You must be signed in to change notification settings - Fork 738
invert check condition #30127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invert check condition #30127
Conversation
|
⚪
🟢 |
|
⚪
🟢 |
|
🟢 |
|
⚪
🟢 |
|
⚪
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes incorrect usage of the Y_ENSURE macro in two methods of the TFlatDbWrapper test class. The original code passed only a string literal to Y_ENSURE, which would always evaluate to true (truthy), preventing the intended assertion from triggering. The fix adds an explicit false condition as the first parameter, ensuring these unsupported methods properly fail with an error message when called.
- Corrects
Y_ENSUREmacro usage to properly assert failure conditions - Fixes two methods (
InitandFinishTransaction) that should always fail with "Not supported" errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
#30109
Changelog entry
...
Changelog category
Description for reviewers
...