Skip to content

Conversation

@ubyte
Copy link
Collaborator

@ubyte ubyte commented Dec 4, 2025

#30109

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@ydbot
Copy link
Collaborator

ydbot commented Dec 4, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

2025-12-04 12:16:18 UTC Pre-commit check linux-x86_64-release-asan for e6c5e92 has started.
2025-12-04 12:16:34 UTC Artifacts will be uploaded here
2025-12-04 12:18:40 UTC ya make is running...
🟢 2025-12-04 12:22:29 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
634 634 0 0 0 0

🟢 2025-12-04 12:22:36 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

2025-12-04 12:16:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for e6c5e92 has started.
2025-12-04 12:16:38 UTC Artifacts will be uploaded here
2025-12-04 12:18:44 UTC ya make is running...
🟢 2025-12-04 12:21:50 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
642 642 0 0 0 0

🟢 2025-12-04 12:21:57 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

🟢 2025-12-04 12:18:12 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

2025-12-04 13:44:49 UTC Pre-commit check linux-x86_64-release-asan for f08ce33 has started.
2025-12-04 13:45:05 UTC Artifacts will be uploaded here
2025-12-04 13:47:13 UTC ya make is running...
🟢 2025-12-04 13:50:41 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
634 634 0 0 0 0

🟢 2025-12-04 13:50:48 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

2025-12-04 13:44:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for f08ce33 has started.
2025-12-04 13:45:08 UTC Artifacts will be uploaded here
2025-12-04 13:47:13 UTC ya make is running...
🟢 2025-12-04 13:50:08 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
642 642 0 0 0 0

🟢 2025-12-04 13:50:16 UTC Build successful.

@ubyte ubyte marked this pull request as ready for review December 4, 2025 16:16
Copilot AI review requested due to automatic review settings December 4, 2025 16:16
@ubyte ubyte requested a review from a team as a code owner December 4, 2025 16:16
@ubyte ubyte enabled auto-merge (squash) December 4, 2025 16:16
Copilot finished reviewing on behalf of ubyte December 4, 2025 16:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect usage of the Y_ENSURE macro in two methods of the TFlatDbWrapper test class. The original code passed only a string literal to Y_ENSURE, which would always evaluate to true (truthy), preventing the intended assertion from triggering. The fix adds an explicit false condition as the first parameter, ensuring these unsupported methods properly fail with an error message when called.

  • Corrects Y_ENSURE macro usage to properly assert failure conditions
  • Fixes two methods (Init and FinishTransaction) that should always fail with "Not supported" errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ubyte ubyte merged commit 1c3ccfd into main Dec 5, 2025
15 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Dec 5, 2025

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3 ▶  Backport

▶  Backport manual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants