Skip to content

Conversation

@dahbka-lis
Copy link
Member

@dahbka-lis dahbka-lis commented Oct 8, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

  • Remove repeated code to create ServerLessDB, add more checks for columns of tables (SS ut for column building).
  • Add compatibility tests for DEFAULT columns (create table, alter table add column) for all types of DS.

...

@dahbka-lis dahbka-lis requested a review from a team as a code owner October 8, 2025 16:54
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

gridnevvvit
gridnevvvit previously approved these changes Oct 9, 2025
ijon
ijon previously approved these changes Oct 9, 2025
@dahbka-lis dahbka-lis dismissed stale reviews from ijon and gridnevvvit via f4b371d October 9, 2025 12:32
@dahbka-lis dahbka-lis requested a review from ijon October 9, 2025 12:32
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

2025-10-09 12:35:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for ae485b1 has started.
2025-10-09 12:35:59 UTC Artifacts will be uploaded here
2025-10-09 12:39:25 UTC ya make is running...
🟢 2025-10-09 12:53:31 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1045 1041 0 0 3 1

🟢 2025-10-09 12:53:33 UTC Build successful.
🟢 2025-10-09 12:54:16 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8e11f9f merge: ae485b1 diff diff %
ydbd size 2 418 016 288 Bytes 2 418 016 288 Bytes 0 Bytes 0.000%
ydbd stripped size 515 025 544 Bytes 515 025 544 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

2025-10-09 12:36:26 UTC Pre-commit check linux-x86_64-release-asan for ae485b1 has started.
2025-10-09 12:36:40 UTC Artifacts will be uploaded here
2025-10-09 12:39:22 UTC ya make is running...
🟡 2025-10-09 13:07:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
883 780 0 16 87 0

🟢 2025-10-09 13:07:46 UTC Build successful.
🟢 2025-10-09 13:08:02 UTC ydbd size 3.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8e11f9f merge: ae485b1 diff diff %
ydbd size 4 021 700 504 Bytes 4 021 700 408 Bytes -96 Bytes -0.000%
ydbd stripped size 1 494 054 912 Bytes 1 494 054 848 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis merged commit 0f7ef7c into ydb-platform:main Oct 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compatibility tests for DEFAULT columns (CREATE TABLE, ALTER TABLE ADD COLUMN)

3 participants