Skip to content

Incorrect WasTheLastBlobBig value at the start of the partition #26560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

Incorrect WasTheLastBlobBig value at the start of the partition #26560

merged 2 commits into from
Oct 13, 2025

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Oct 8, 2025 •
edited
Loading

Changelog entry

If there are blobs in the head of the CompactionZone, then WasTheLastBlobBig should be set to true.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested review from a team as code owners October 8, 2025 12:23
@Alek5andr-Kotov Alek5andr-Kotov requested a review from ubyte October 8, 2025 12:23
@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

🟢 2025-10-13 04:59:02 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

⚪ 2025-10-08 12:29:12 UTC Pre-commit check linux-x86_64-release-asan for f86f1d3 has started.
⚪ 2025-10-08 12:29:26 UTC Artifacts will be uploaded here
🔴 2025-10-08 12:31:27 UTC Graph compare failed, see the logs.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

⚪ 2025-10-08 12:30:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for f86f1d3 has started.
⚪ 2025-10-08 12:30:47 UTC Artifacts will be uploaded here
🔴 2025-10-08 12:33:25 UTC Graph compare failed, see the logs.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

⚪ 2025-10-10 07:45:02 UTC Pre-commit check linux-x86_64-release-asan for 6965fd1 has started.
⚪ 2025-10-10 07:45:17 UTC Artifacts will be uploaded here
🔴 2025-10-10 07:47:26 UTC Graph compare failed, see the logs.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

⚪ 2025-10-10 07:45:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6965fd1 has started.
⚪ 2025-10-10 07:45:16 UTC Artifacts will be uploaded here
🔴 2025-10-10 07:47:20 UTC Graph compare failed, see the logs.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 04:53:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3aac49b has started.
⚪ 2025-10-13 04:53:48 UTC Artifacts will be uploaded here
⚪ 2025-10-13 04:57:23 UTC ya make is running...
⚫ 2025-10-13 05:29:08 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 04:54:03 UTC Pre-commit check linux-x86_64-release-asan for 3aac49b has started.
⚪ 2025-10-13 04:54:16 UTC Artifacts will be uploaded here
⚪ 2025-10-13 04:57:52 UTC ya make is running...
⚫ 2025-10-13 05:29:06 UTC Check cancelled

@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: LOGBROKER-10002 Incorrect WasTheLastBlobBig value at the start of the partition Oct 13, 2025
@Alek5andr-Kotov Alek5andr-Kotov removed the request for review from a team October 13, 2025 04:58
@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 05:30:41 UTC Pre-commit check linux-x86_64-release-asan for e60fbe7 has started.
⚪ 2025-10-13 05:34:28 UTC Artifacts will be uploaded here
⚪ 2025-10-13 05:38:49 UTC ya make is running...
🟡 2025-10-13 07:45:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17567 17128 0 150 265 24

🟢 2025-10-13 07:45:40 UTC Build successful.
🟢 2025-10-13 07:46:03 UTC ydbd size 3.7 GiB changed* by +25.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6b4a150 merge: e60fbe7 diff diff %
ydbd size 4 025 087 696 Bytes 4 025 113 992 Bytes +25.7 KiB +0.001%
ydbd stripped size 1 495 075 072 Bytes 1 495 086 688 Bytes +11.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 05:30:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for e60fbe7 has started.
⚪ 2025-10-13 05:34:04 UTC Artifacts will be uploaded here
⚪ 2025-10-13 05:38:20 UTC ya make is running...

@alexnick88 alexnick88 enabled auto-merge (squash) October 13, 2025 05:45
@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) October 13, 2025 07:03
@Alek5andr-Kotov Alek5andr-Kotov added the rebase-and-check Rebase PR with the current base branch and check label Oct 13, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 08:48:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 026d1ca has started.
⚪ 2025-10-13 08:49:04 UTC Artifacts will be uploaded here
⚪ 2025-10-13 08:52:52 UTC ya make is running...

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 08:49:37 UTC Pre-commit check linux-x86_64-release-asan for 026d1ca has started.
⚪ 2025-10-13 08:49:41 UTC Artifacts will be uploaded here
⚪ 2025-10-13 08:53:23 UTC ya make is running...
🟡 2025-10-13 10:59:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17567 17154 0 146 249 18

🟢 2025-10-13 10:59:50 UTC Build successful.
🟢 2025-10-13 11:00:14 UTC ydbd size 3.7 GiB changed* by +25.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6af564d merge: 026d1ca diff diff %
ydbd size 4 025 095 864 Bytes 4 025 122 160 Bytes +25.7 KiB +0.001%
ydbd stripped size 1 495 078 048 Bytes 1 495 089 664 Bytes +11.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov mentioned this pull request Oct 13, 2025
Closed
@Alek5andr-Kotov Alek5andr-Kotov removed the request for review from ubyte October 13, 2025 11:47
@Alek5andr-Kotov Alek5andr-Kotov added the rebase-and-check Rebase PR with the current base branch and check label Oct 13, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 13:01:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for ee98b6d has started.
⚪ 2025-10-13 13:01:32 UTC Artifacts will be uploaded here
⚪ 2025-10-13 13:05:14 UTC ya make is running...
🟡 2025-10-13 14:44:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40716 37914 0 10 2760 32

⚪ 2025-10-13 14:44:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-13 15:04:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1141 (only retried tests) 1121 0 2 0 18

⚪ 2025-10-13 15:04:21 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-13 15:20:16 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
566 (only retried tests) 550 0 0 0 16

🟢 2025-10-13 15:20:19 UTC Build successful.
🟢 2025-10-13 15:20:37 UTC ydbd size 2.3 GiB changed* by +14.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 43d3d02 merge: ee98b6d diff diff %
ydbd size 2 420 084 432 Bytes 2 420 099 416 Bytes +14.6 KiB +0.001%
ydbd stripped size 515 415 848 Bytes 515 419 496 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 13:04:44 UTC Pre-commit check linux-x86_64-release-asan for ee98b6d has started.
⚪ 2025-10-13 13:04:53 UTC Artifacts will be uploaded here
⚪ 2025-10-13 13:08:28 UTC ya make is running...
🟡 2025-10-13 15:13:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17578 17114 0 194 258 12

🟢 2025-10-13 15:13:45 UTC Build successful.
🟢 2025-10-13 15:14:07 UTC ydbd size 3.7 GiB changed* by +29.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ff2b01d merge: ee98b6d diff diff %
ydbd size 4 025 781 648 Bytes 4 025 812 024 Bytes +29.7 KiB +0.001%
ydbd stripped size 1 495 229 728 Bytes 1 495 245 440 Bytes +15.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit f9391ba into ydb-platform:main Oct 13, 2025
20 of 22 checks passed
ydbot pushed a commit that referenced this pull request Oct 13, 2025
@Alek5andr-Kotov @ydbot
Incorrect WasTheLastBlobBig value at the start of the partition (#26560)
7cdd600
@ydbot ydbot mentioned this pull request Oct 13, 2025
Merged
ydbot pushed a commit that referenced this pull request Oct 13, 2025
@Alek5andr-Kotov @ydbot
Incorrect WasTheLastBlobBig value at the start of the partition (#26560)
b20a4ae
@ydbot ydbot mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alek5andr-Kotov @alexnick88