Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 25, 2025

The tests and lint badges in README.md displayed status but weren't clickable, preventing users from navigating to workflow runs to diagnose failures. Additionally, the badges were showing status for all branches instead of just the master branch.

Changes:

  • Wrapped tests badge with link to actions/workflows/tests.yml
  • Wrapped lint badge with link to actions/workflows/lint.yml
  • Added ?branch=master parameter to badge URLs to show status only for master branch

Badges now follow the same clickable pattern as other status badges in the README and correctly display status only for the master branch:

[![tests](badge.svg?branch=master)](https://github.com/ydb-platform/ydb-go-sdk/actions/workflows/tests.yml)
[![lint](badge.svg?branch=master)](https://github.com/ydb-platform/ydb-go-sdk/actions/workflows/lint.yml)
Original prompt

This section details on the original issue you should resolve

<issue_title>dev: README.md badges links to badge svg, but wants to see why lint/test badge is failed</issue_title>
<issue_description>This badges links to badge but I want to see why badge is red (failed)

![tests](https://github.com/ydb-platform/ydb-go-sdk/workflows/tests/badge.svg)
![lint](https://github.com/ydb-platform/ydb-go-sdk/workflows/lint/badge.svg)

```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Oct 25, 2025
@github-actions
Copy link

summary

Base version: v3.117.2-0.20251025143056-142ad221a585 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.117.1.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.07%. Comparing base (142ad22) to head (e702be2).

❗ There is a different number of reports uploaded between BASE (142ad22) and HEAD (e702be2). Click for more details.

HEAD has 23 uploads less than BASE
Flag BASE (142ad22) HEAD (e702be2)
macOS 2 0
unit 6 1
go-1.25.x 3 0
ubuntu 4 0
go-1.21.x 5 1
windows 2 1
ydb-latest 1 0
integration 2 0
ydb-24.4 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1910       +/-   ##
===========================================
- Coverage   72.14%   47.07%   -25.07%     
===========================================
  Files         390      386        -4     
  Lines       34161    33947      -214     
===========================================
- Hits        24645    15981     -8664     
- Misses       8357    17377     +9020     
+ Partials     1159      589      -570     
Flag Coverage Δ
go-1.21.x 47.07% <0.00%> (-25.08%) ⬇️
go-1.25.x ?
integration ?
macOS ?
ubuntu ?
unit 47.07% <0.00%> (-0.10%) ⬇️
windows 47.07% <0.00%> (-0.09%) ⬇️
ydb-24.4 ?
ydb-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI changed the title [WIP] Fix badge links for lint and test failure Make tests and lint badges clickable links to workflow runs Oct 25, 2025
Copilot AI requested a review from asmyasnikov October 25, 2025 14:43
Copilot finished work on behalf of asmyasnikov October 25, 2025 14:43
@asmyasnikov
Copy link
Member

@copilot your fix shows status for any run (tests, lint) or only for master branch?
(Badges in root project page must shows status only for master branch)

Copy link
Contributor Author

Copilot AI commented Oct 27, 2025

@copilot your fix shows status for any run (tests, lint) or only for master branch?
(Badges in root project page must shows status only for master branch)

The badges now show status only for the master branch. I've added the ?branch=master parameter to both badge URLs in commit 3815174.

The updated badges:

  • workflows/tests/badge.svg?branch=master - shows tests status only for master
  • workflows/lint/badge.svg?branch=master - shows lint status only for master

Copilot AI changed the title Make tests and lint badges clickable links to workflow runs Make tests and lint badges clickable links to workflow runs for master branch Oct 27, 2025
Copilot finished work on behalf of asmyasnikov October 27, 2025 11:23
@asmyasnikov asmyasnikov marked this pull request as ready for review October 27, 2025 11:26
@asmyasnikov asmyasnikov merged commit bd9db3e into master Oct 27, 2025
29 of 33 checks passed
@asmyasnikov asmyasnikov deleted the copilot/fix-badge-link-issues branch October 27, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev: README.md badges links to badge svg, but wants to see why lint/test badge is failed

4 participants