feat: use same duration functions #3156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
requested review from
Raubzeug,
adameat and
artemmufazalov
as code owners
Copilot finished reviewing on behalf of
astandrik
December 2, 2025 10:48
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors duration formatting functions to use more consistent and descriptive naming conventions. The changes rename formatUptimeInSeconds to formatDurationSeconds and formatMsToUptime to formatDurationMs to better reflect their generic duration formatting purpose rather than being specific to uptime.
- Renamed duration formatting functions to more descriptive names
- Updated all usages across the codebase consistently
- Improved the Operations duration column to use the standardized formatting approach
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/dataFormatters/dataFormatters.ts | Renamed core formatting functions and updated documentation |
| src/utils/dataFormatters/test/formatDuration.test.ts | Updated test suite to use new function names |
| src/containers/Tenant/Diagnostics/Partitions/columns/columns.tsx | Updated partition lag/idle time formatting calls |
| src/containers/Tenant/Diagnostics/Consumers/columns/columns.tsx | Updated consumer lag/idle time formatting calls |
| src/containers/Tenant/Diagnostics/Consumers/TopicStats/ConsumersTopicStats.tsx | Updated topic stats formatting calls |
| src/containers/Operations/columns.tsx | Replaced custom duration formatting with standardized function and removed unnecessary imports |
| src/components/VDiskPopup/VDiskPopup.tsx | Updated VDisk replication time formatting |
| src/components/VDiskInfo/VDiskInfo.tsx | Updated VDisk info time formatting and imports |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Raubzeug
previously approved these changes
Dec 2, 2025
astandrik
force-pushed
the
astandrik.3133
branch
from
e22effc to
e22147f
Compare
Raubzeug
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3133
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.34 MB | Main: 62.34 MB
Diff: 0.28 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information