Skip to content

err shadowed in goroutine which effectively make errcheck after <-done channel useless#78

Open
sivukhin wants to merge 1 commit intoyanzay:masterfrom
sivukhin:fix-err-shadowing-bug
Open

err shadowed in goroutine which effectively make errcheck after <-done channel useless#78
sivukhin wants to merge 1 commit intoyanzay:masterfrom
sivukhin:fix-err-shadowing-bug

Conversation

@sivukhin
Copy link

function-level err variable were shadowed by goroutine local variable which effectively make useless errcheck after finish of goroutine:

<-done // post request is done
if err != nil {
	return err
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant