Patch 2#813
Open
Tonsofattraction wants to merge 3 commits into
Open
Conversation
szypulka
suggested changes
Nov 11, 2019
| AbstractCriterion.__init__(self) | ||
| self.seconds_count = 0 | ||
| params = param_str.split(',') | ||
| params = param_str.split(',', 3) |
Contributor
There was a problem hiding this comment.
Should it be 2, not 3?
In case of 2 as a parameter self.tag would include the rest of the string with commas,
in case of 3 all these trailing commas will be dropped.
params_3 = param_str.split(',', 3)
tag = params_3[2].strip() if len(params_3) == 3 else None
print(tag)
None
params_2 = param_str.split(',', 2)
tag = params_2[2].strip() if len(params_2) == 3 else None
print(tag)
'long tag, with commas'
Contributor
There was a problem hiding this comment.
@Tonsofattraction could you comment this, please?
Contributor
Author
There was a problem hiding this comment.
My mistake, this particular criterion accepts 3 params at most. May be we should check other criteria as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support comma in tags for autostop