fix: correctly clear startup-schedule when recrawl job is stopped (#766) - #772
Open
songproducer wants to merge 1 commit into
Open
fix: correctly clear startup-schedule when recrawl job is stopped (#766)#772songproducer wants to merge 1 commit into
songproducer wants to merge 1 commit into
Conversation
…cy#766) PR yacy#757 added auto-restart of the recrawl job on peer boot by writing event_kind=regular/event_action=startup to the API table when the job starts. On stop, it tried to clear this by calling selectLastExecutedApiCall() with the stoprecrawl POST - but that POST contains 'stoprecrawl' while the stored API URL has 'recrawlnow', so the URL-based lookup returns null and the off-switch is never written. Fix: on stoprecrawl, scan the API table directly for any row belonging to IndexReIndexMonitor_p with event_action=startup and clear it there. This ensures that stopping the job before shutdown prevents it from auto-restarting on the next boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #757 added auto-restart of the recrawl job on peer boot by writing event_kind=regular/event_action=startup to the API table when the job starts. On stop, it tried to clear this by calling selectLastExecutedApiCall() with the stoprecrawl POST - but that POST contains 'stoprecrawl' while the stored API URL has 'recrawlnow', so the URL-based lookup returns null and the off-switch is never written.
Fix: on stoprecrawl, scan the API table directly for any row belonging to IndexReIndexMonitor_p with event_action=startup and clear it there. This ensures that stopping the job before shutdown prevents it from auto-restarting on the next boot.