fix zclient retry logic for customized callback and test#39
Open
xyuanlu wants to merge 15 commits into
Open
Conversation
Add new submodule meta client - a generic metadata client
Add listener interfaces and factory class for metaclient interface
Add Meta client factory and ZkMetaClient constructor
…implementation (apache#2333) Prepare zkclient for meta-client DataChangeListener add new method in IZkDataListener Implement boolean flag connectOnInit in zkclient for decoupling Override equals and hashcode for the converter class
Add basic CRUD for ZkMetaClient and test
Metaclient - Op and OpResult Logic for transactional suppor
Metaclient - Implementation of Create from CRUD operations
* Implement data change listener for ZkMetaClient and test
… zkclient (apache#2346) Prepare zkclient and implement new adapter for child change listener.
1. Implementation of the transactionOp() operation method in zkMetaClient. This method enables transactional support by converting metaclient operations into zk ops and running the zk.multi() method. The results are converted back from zk opResults to metaclient opResults. 2. Created a separate util class zkMetaClientUtil for Util functions and the logic behind the implementation of transactionOp().
Refactoring MetaClient Exception. Creating separate exception directory.
Rename and reformat metaclient test and util
xyuanlu
force-pushed
the
metaclient
branch
3 times, most recently
from
2d3800a to
6c53496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)