XWIKI-23420: Notifications that aren't pre-filtered in time aren't sent by schedulers #4854
+198
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note: was previously #4782 but the branch has been renamed. |
surli
changed the title
michitux
requested changes
Nov 28, 2025
Contributor
michitux
left a comment
michitux
left a comment
There was a problem hiding this comment.
The since-versions need to be adjusted (17.10.0 has already been released) and I have some comments regarding the migration.
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
…nt by schedulers
* Provide a new solr event field for storing prefiltering date and use
that date instead of event date when getting events for sending
emails
…ent by schedulers * Fix coverage * Fix missing version to update schema * Use setAtomic
…nt by schedulers * Fix bug with migration
surli
force-pushed
the
feature-deploy-XWIKI-23420
branch
from
8cf4374 to
46c5452
Compare
Member
Author
I'm aware about that, but I'm waiting to know exactly where it's merged before changing all versions FTR. |
…nt by schedulers * Start improvments on migration
…nt by schedulers * Improve migration following Michael's review
michitux
requested changes
Dec 1, 2025
Contributor
michitux
left a comment
michitux
left a comment
There was a problem hiding this comment.
It seems you have some confusing and not really used code left over from the index-based pagination, I've added some comments.
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
...java/org/xwiki/eventstream/store/solr/internal/migration/SolrDocumentMigration171000000.java
Outdated
Show resolved
Hide resolved
…nt by schedulers * Minor fix * Change version
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
…nt by schedulers (#4854) * Provide a new solr event field for storing prefiltering date and use that date instead of event date when getting events for sending emails * Fix coverage * Fix missing version to update schema * Use setAtomic * Fix bug with migration * Start improvments on migration * Improve migration following Michael's review * Minor fix * Change version (cherry picked from commit 6d7320d)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
surli
added a commit
that referenced
this pull request
Dec 3, 2025
…nt by schedulers (#4854) * Provide a new solr event field for storing prefiltering date and use that date instead of event date when getting events for sending emails * Fix coverage * Fix missing version to update schema * Use setAtomic * Fix bug with migration * Start improvments on migration * Improve migration following Michael's review * Minor fix * Change version (cherry picked from commit 6d7320d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23420
Changes
Description
Clarifications
Screenshots & Video
Executed Tests
All impacted modules were rebuilt with quality profile. All tests of xwiki-platform-notification-test-docker have been executed.
Manual test to perform:
Expected merging strategy