fix(desktop): make evaluation evidence explicit and fail closed - #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modeandoutcomefieldsWhy
The desktop app inferred evaluation semantics from missing fields and string values. A dry run could therefore be mistaken for proof of quality, later dry runs could hide graded failures, and malformed evidence could disappear from the release decision. The new contract makes those states explicit and preserves the distinction end to end.
Impact
Release readiness now requires current passing graded evidence for every skill. Dry runs remain useful as structural validation but cannot satisfy that gate. Existing legacy trace history is still read conservatively; ambiguous legacy JSON is rejected visibly.
Validation
npm test— 60 Node tests passed; repository validators passedpython -m pytest tests/ scripts/tests/ -q— 373 passed--all --dry-run --jsonoutput parsed successfullycargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --locked— 83 Rust unit tests plus all integration tests passedcargo build --lockedFollow-up
PR2 will stack the runtime-reliability work on this branch: versioned/locked/atomic trace persistence, bounded subprocess execution, reliable worker completion, and explicit CLI argument handling.