Skip to content

Set minSdk 21 so consumers stop inheriting implied permissions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blackbbc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set minSdk 21 so consumers stop inheriting implied permissions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions androidsvg/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ android {
compileSdk 34

defaultConfig {
// Must stay set. Without it AGP writes minSdkVersion="1" into the AAR
// manifest, and since AGP strips targetSdkVersion from library manifests
// entirely, consumers fall back to targetSdk == minSdk == 1. That trips the
// manifest merger's implied-permission rules (targetSdk < 4 -> READ_PHONE_STATE;
// targetSdk < 16 + app requests WRITE_EXTERNAL_STORAGE -> READ_EXTERNAL_STORAGE),
// silently adding uncapped storage/phone permissions to every consuming app.
minSdk 21

testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
Expand Down
2 changes: 1 addition & 1 deletion androidsvg/publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
apply plugin: 'maven-publish'


def versionName = '1.6'
def versionName = '1.6.1'

def libraryName = 'AndroidSVG'
def libraryDescription = 'SVG rendering library for Android.'
Expand Down