-
-
Notifications
You must be signed in to change notification settings - Fork 870
get.sh: support dnf #6847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
get.sh: support dnf #6847
Conversation
Summary of ChangesHello @black-desk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the dnf
package manager to the get.sh
installation script, which is a great improvement for users on modern Fedora-based distributions. The implementation is sound, and I have one suggestion to make the dnf
command more efficient by combining two install
calls into one. The change correctly updates the bootstrap script and the associated help message.
Signed-off-by: Chen Linxuan <[email protected]>
4776ab3
to
dcffb16
Compare
Does it ready now? |
It seems to work on my machine. But I am not sure about whether we actually install all dependencies we need here or not. |
git, @development-tools is required, readline-devel is optional and is only needed for REPL, and bzip2 is also optional and is needed for package management. |
Signed-off-by: Chen Linxuan [email protected]