Skip to content

Conversation

black-desk
Copy link

Signed-off-by: Chen Linxuan [email protected]

Copy link
Contributor

Summary of Changes

Hello @black-desk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the get.sh script by integrating support for the dnf package manager. This change broadens the script's compatibility, allowing users on Fedora, RHEL 8+, and CentOS Stream 8+ systems to seamlessly install necessary development dependencies. The update ensures a smoother setup experience across a wider array of Linux distributions.

Highlights

  • DNF Package Manager Support: The get.sh script now includes support for the dnf package manager, enabling automatic installation of development tools on systems using it.
  • Dependency Installation Logic: The install_tools function has been updated to detect dnf and use it to install git, readline-devel, bzip2, and the @development-tools group.
  • Improved Error Messaging: The dependency installation failure message has been updated to explicitly list dnf among the supported package managers, providing clearer guidance to users.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the dnf package manager to the get.sh installation script, which is a great improvement for users on modern Fedora-based distributions. The implementation is sound, and I have one suggestion to make the dnf command more efficient by combining two install calls into one. The change correctly updates the bootstrap script and the associated help message.

Signed-off-by: Chen Linxuan <[email protected]>
@black-desk black-desk marked this pull request as draft September 23, 2025 09:35
@waruqi
Copy link
Member

waruqi commented Sep 26, 2025

Does it ready now?

@black-desk
Copy link
Author

Does it ready now?

It seems to work on my machine.

But I am not sure about whether we actually install all dependencies we need here or not.

@waruqi
Copy link
Member

waruqi commented Oct 1, 2025

Does it ready now?

It seems to work on my machine.

But I am not sure about whether we actually install all dependencies we need here or not.

git, @development-tools is required, readline-devel is optional and is only needed for REPL, and bzip2 is also optional and is needed for package management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants