-
-
Notifications
You must be signed in to change notification settings - Fork 490
Auto-update openjph to 0.25.2 #8614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on keeping the project's dependencies current by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the openjph package to version 0.25.2. While the version update itself is correct, I've identified a pre-existing issue in the package's configuration that prevents any version from being downloaded and installed. My review includes a comment with a suggested fix to make the package functional. Addressing this would be beneficial.
| add_urls("https://github.com/aous72/OpenJPH/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/aous72/OpenJPH.git") | ||
|
|
||
| add_versions("0.25.2", "ae5f09562cb811cb2fb881c5eb74583e18db941848cfa3c35787e2580f3defc6") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this correctly adds the new version, it will not be installable due to a pre-existing issue in this package definition. The upstream project's git tags are prefixed with v (e.g., v0.25.2), but the download URL on line 6 is missing this prefix. This causes all version downloads to fail with a 404 error.
The correct fix is to update line 6 to prepend v to the version:
add_urls("https://github.com/aous72/OpenJPH/archive/refs/tags/v$(version).tar.gz",
"https://github.com/aous72/OpenJPH.git")Since this change is outside the modified lines of this PR, I'm providing it as a comment. I strongly recommend applying this fix to make the openjph package functional.
New version of openjph detected (package version: 0.24.2, last github version: 0.25.2)