Skip to content

add feature: add support in windows platform #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robinsssson wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add feature: add support in windows platform #1

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9826d12
add feature: add support in windows platform
Nov 28, 2024
e1bfb2a
fix: change the scripts to toolchain
Nov 28, 2024
157e9a2
fix: change the scripts to toolchain
Nov 28, 2024
f599ae8
refresh .gitignore
Nov 28, 2024
0f77424
refresh .gitignore
Nov 28, 2024
84d7629
fix: change format
Nov 28, 2024
e3c8053
fix: delete the logging file
Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions armgcc.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,17 @@ function use_toolchain(sdk_path)
set_kind("cross")
set_description("Stm32 Arm Embedded Compiler")
set_sdkdir(sdk_path)
set_toolset("cc", "arm-none-eabi-gcc")
set_toolset("ld", "arm-none-eabi-gcc")
set_toolset("ar", "arm-none-eabi-ar")
set_toolset("as", "arm-none-eabi-gcc")
if is_plat("windows") then
Copy link

@waruqi waruqi Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should set toolset and call toolchain:is_plat in on_load.

https://github.com/xmake-io/xmake/blob/2c973f5431c7fc907ed52a01698f1dd51804507d/xmake/toolchains/armcc/xmake.lua#L46

on_load(function (toolchain)
    if toolchain:is_plat("windows") then
        toolchain:set("toolset", "cc", "...")
    end
end)

set_toolset("cc", "arm-none-eabi-gcc.exe")
Copy link

@waruqi waruqi Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 4 spaces instead of tab

set_toolset("ld", "arm-none-eabi-gcc.exe")
set_toolset("ar", "arm-none-eabi-ar.exe")
set_toolset("as", "arm-none-eabi-gcc.exe")
else
set_toolset("cc", "arm-none-eabi-gcc")
set_toolset("ld", "arm-none-eabi-gcc")
set_toolset("ar", "arm-none-eabi-ar")
set_toolset("as", "arm-none-eabi-gcc")
end
toolchain_end()
set_toolchains("arm-gcc")
end
Expand All @@ -46,13 +53,24 @@ rule("arm-gcc")
local out = target:targetfile() or ""
local gen_fi = "build/"..target:name()
print(string.format("%s => %s", out, gen_fi))
os.exec("arm-none-eabi-objcopy -Obinary "..out.." "..gen_fi..".bin")
-- https://github.com/xmake-io/xmake/discussions/2125
-- os.exec("arm-none-eabi-objdump -S "..out.." > "..gen_fi..".asm")
-- local asm = os.iorun("arm-none-eabi-objdump -S build/cross/cortex-m4/release/minimal-proj")
-- io.writefile(gen_fi..".asm", asm)
os.execv("arm-none-eabi-objdump", {"-S", out}, {stdout=gen_fi..".asm"})
os.exec("arm-none-eabi-objcopy -O ihex "..out.." "..gen_fi..".hex")
if is_plat("windows") then
Copy link

@waruqi waruqi Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toolchain:is_plat

os.exec("arm-none-eabi-objcopy.exe -Obinary "..out.." "..gen_fi..".bin")
Copy link

@waruqi waruqi Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add spaces .. out ..

Copy link

@waruqi waruqi Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please use os.execv

-- https://github.com/xmake-io/xmake/discussions/2125
-- os.exec("arm-none-eabi-objdump -S "..out.." > "..gen_fi..".asm")
-- local asm = os.iorun("arm-none-eabi-objdump -S build/cross/cortex-m4/release/minimal-proj")
-- io.writefile(gen_fi..".asm", asm)
os.execv("arm-none-eabi-objdump.exe", {"-S", out}, {stdout=gen_fi..".asm"})
Copy link

@waruqi waruqi Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add spaces =

os.exec("arm-none-eabi-objcopy.exe -O ihex "..out.." "..gen_fi..".hex")
else
os.exec("arm-none-eabi-objcopy -Obinary "..out.." "..gen_fi..".bin")
-- https://github.com/xmake-io/xmake/discussions/2125
-- os.exec("arm-none-eabi-objdump -S "..out.." > "..gen_fi..".asm")
-- local asm = os.iorun("arm-none-eabi-objdump -S build/cross/cortex-m4/release/minimal-proj")
-- io.writefile(gen_fi..".asm", asm)
os.execv("arm-none-eabi-objdump", {"-S", out}, {stdout=gen_fi..".asm"})
os.exec("arm-none-eabi-objcopy -O ihex "..out.." "..gen_fi..".hex")
end
os.mv(out, gen_fi .. ".elf") -- add .elf file
-- -I binary
-- $(Q) $(OBJ_COPY) -O ihex $@ $(BUILD_DIR)/$(TARGET).hex
-- $(Q) $(OBJ_COPY) -O binary $@ $(BUILD_DIR)/$(TARGET).bin
Expand Down