chore: update xline pod of ci,add probe,volume and security config.#745
chore: update xline pod of ci,add probe,volume and security config.#745liangyuanpeng wants to merge 1 commit into
Conversation
25ee523 to
2273ab8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 75.55% 75.13% -0.42%
==========================================
Files 180 176 -4
Lines 26938 26852 -86
Branches 26938 26852 -86
==========================================
- Hits 20353 20176 -177
- Misses 5366 5465 +99
+ Partials 1219 1211 -8 ☔ View full report in Codecov by Sentry. |
2273ab8 to
5a00680
Compare
| failureThreshold: 24 | ||
| httpGet: | ||
| host: 127.0.0.1 | ||
| path: /metrics |
There was a problem hiding this comment.
This probably requires a better one, but I haven't found one. Remind me if i missed something,Thanks.
There was a problem hiding this comment.
Basically, this requires the application to have /readyz and /livez interfaces. etcd is also implement the grpc for it etcd-io/etcd@293f087#diff-ab6fb0684315e16355f6ebe0f4b3cf860b9b2ff5a0fe1b4e4308a680b19f1b0c
|
cc @Phoenix500526 @bsbds |
Signed-off-by: Lan Liang <gcslyp@gmail.com>
5a00680 to
6cc1026
Compare
|
kindly ping :) |
Please briefly answer these questions:
The content is basically copied from etcd pod yaml,happy to update it if we have better config.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)