upd:HistogramView添加圆角 - #278
Open
nicknull wants to merge 3 commits into
Open
Conversation
Owner
|
roundRect方法在 新代码入侵严重，如果没有配置新参数，应当执行原有逻辑，不然老项目npm更新一下就趴窝了。 新加的代码没有缩进。 新代码逻辑是否正确需要多种position配置下测试，绘制下半部分的dynamicRadius变量未定义。 |
Author
|
好的 我会修改这部分代码 |
Author
|
@xiangyuecn 你好 现在这样不知是否可行 |
Owner
|
默认值不要影响老代码，如果没有配置新参数，需要执行原有绘制逻辑（有项目会绘制几千条，原有代码绘制逻辑简单），不然老项目npm更新一下就趴窝了 代码有几个地方还是没有缩进 浏览器支持roundRect的时候，不需要调用自己的方法，不支持的时候才走自己的代码 这个pr目前不会合并到主分支，有同样需要圆角的可以先复制这个代码使用 |
Author
|
已经改为配置项了且默认走原有的业务逻辑 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.