docs: list feature-gated models#182
Open
peter941221 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the README.md file to document support for DeepSeek-V2-Lite and Kimi-K2 models. Feedback was provided regarding an inconsistency in the supported models table, where the string "feature-gated" was incorrectly placed in the Params column instead of the Status column. A suggestion was provided to align these rows with the correct table structure and include the actual parameter counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README supported-models table drifted behind the server's actual model detection logic.
Failure mechanism:
pegainfer-server/src/server_engine.rsalready exposes feature-gatedDeepSeekV2LiteandKimiK2model linesSemantic change:
DeepSeek-V2-LiteandKimi-K2to the README supported-models tablepegainfer-serverwith the matching--features ...flag before launchTesting:
pegainfer-server/src/server_engine.rs:10-18,:44-58, and:75-92