Skip to content

Implement cas for Int and Long arrays. #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
totalslacker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement cas for Int and Long arrays. #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions larray/src/main/scala/xerial/larray/LArray.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ trait LArray[A] extends LSeq[A] with WritableByteChannel {
@inline def putLong(offset: Long, v: Long) = { unsafe.putLong(address + offset, v); v}
@inline def putDouble(offset: Long, v: Double) = { unsafe.putDouble(address + offset, v); v }

@inline def casInt(offset: Long, exp: Int, v: Int) = { unsafe.compareAndSwapInt(null, address + offset, exp, v) }
@inline def casLong(offset: Long, exp: Long, v: Long) = { unsafe.compareAndSwapLong(null, address + offset, exp, v)}

}


Expand Down Expand Up @@ -813,6 +816,10 @@ class LIntArray(val size: Long, private[larray] val m: Memory)(implicit val allo
v
}

def cas(i: Long, exp: Int, v: Int) = {
unsafe.compareAndSwapInt(null, m.address + (i << 2), exp, v)
}

/**
* Byte size of an element. For example, if A is Int, its elementByteSize is 4
*/
Expand Down Expand Up @@ -849,6 +856,10 @@ class LLongArray(val size: Long, private[larray] val m: Memory)(implicit val all
v
}

def cas(i: Long, exp: Long, v: Long) = {
unsafe.compareAndSwapLong(null, m.address + (i << 2), exp, v)
}

def view(from: Long, to: Long) = new LArrayView.LLongArrayView(this, from, to - from)

}
Expand Down
52 changes: 52 additions & 0 deletions larray/src/test/scala/xerial/larray/LArrayTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,58 @@ class LArrayTest extends LArraySpec {
}
}

"implement cas correctly" in {
info("cas test")

val l = new LIntArray(3)
try {
l(0) = 1
l(1) = 2
l(2) = 3
l(0) should be (1)
l(1) should be (2)
l(2) should be (3)

l.cas(0, 1, 2) should be (true)
l(0) should be (2)

l.casInt(0, 2, 3) should be (true)
l(0) should be (3)

l.cas(0, 1, 1) should be (false)
l(0) should be (3)
}
finally {
l.free
}
}

"implement cas correctly for LLongArray" in {
info("cas test")

val l = new LLongArray(3)
try {
l(0) = 1
l(1) = 2
l(2) = 3
l(0) should be (1L)
l(1) should be (2L)
l(2) should be (3L)

l.cas(0, 1L, 2L) should be (true)
l(0) should be (2L)

l.casLong(0, 2, 3) should be (true)
l(0) should be (3L)

l.cas(0, 1L, 1L) should be (false)
l(0) should be (3L)
}
finally {
l.free
}
}

"read/write data to Array[Byte]" taggedAs ("rw") in {
val l = LArray(1, 3)
val b = new Array[Byte](l.byteLength.toInt)
Expand Down