dialects: (memref) Add ViewOp#5682
Open
HendrikKlug-synthara wants to merge 1 commit intoxdslproject:hk/memref/view_opfrom
Open
dialects: (memref) Add ViewOp#5682HendrikKlug-synthara wants to merge 1 commit intoxdslproject:hk/memref/view_opfrom
HendrikKlug-synthara wants to merge 1 commit intoxdslproject:hk/memref/view_opfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hk/memref/view_op #5682 +/- ##
==================================================
Coverage 86.27% 86.28%
==================================================
Files 404 404
Lines 57408 57434 +26
Branches 6666 6671 +5
==================================================
+ Hits 49531 49556 +25
- Misses 6323 6324 +1
Partials 1554 1554 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Feb 25, 2026
Comment on lines
1021
to
1030
superlopuh
reviewed
Feb 25, 2026
Member
There was a problem hiding this comment.
Suggested change
| // RUN: MLIR_ROUNDTRIP | |
| // RUN: MLIR_GENERIC_ROUNDTRIP |
superlopuh
reviewed
Feb 25, 2026
Comment on lines
3
to
18
Member
There was a problem hiding this comment.
Can you please drop the outer builtin.module, and use custom syntax everywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation taken from https://github.com/llvm/llvm-project/blob/787ba2426148ff0fa0c0253f6e4cc11e5cfe8361//mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp#L3744
Tests inspired by: https://github.com/llvm/llvm-project/blob/787ba2426148ff0fa0c0253f6e4cc11e5cfe8361/mlir/test/Dialect/MemRef/ops.mlir#L286