Replaced uses of -1 as the dynamic index marker#17
Closed
Conversation
…s not correct in the previous version
… function. Otherwise, the function will not be present in the symbol table of the calling module
…rated IR does not pass the mlir-opt verifier. Tested on all the offload examples
…tion arguments are dereferenced, since HLS is not compatible with pointers to pointers. OpenMP variables in the omp.map.info operations are forwarded and the omp.target operation is forwarded (operands are forwarded to the block operations). Tested with offload/ex1.F90
…y to generate LLVM IR
… earlier in the pipeline. Also, remove attributes from the module, since they are incompatible with the downgrading to LLVM v7
…nly works when called after offload and extract-target, target-to-hls, but it is not enforced yet for debuggability
…e the operands to omp.taget are expected to be in has_device_addr_vars
…nto a new function (previously the omp.target operation was kept inside the function)
…ass, since this is done previously in the pipeline now
… pointer to kernel function
…a block, not a body
It should now be possible to inherit from `ApplyTargetConfig` and override the `_get_config` member function to return a new config.
xDSL now uses a different value for the dynamic index marker - `builtin.DYNAMIC_INDEX` with value `-(2**63)`, which matches the value MLIR uses for this. Now `memref`s, and `tensor`s that use `-1` as the dynamic index get printed with a literal `-1`, rather than `?`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xDSL now uses a different value for the dynamic index marker -
builtin.DYNAMIC_INDEXwith value-(2**63), which matches the value MLIR uses for this.Now
memrefs, andtensors that use-1as the dynamic index get printed with a literal-1, rather than?.Depends on #14
Closes #16