Open
Conversation
Owner
|
The proposed cmake does not explicitly mark relevant functions for export, nor does it support the various configuration options (e.g. built-in hash functions or NSS as alternative to openSSL). It does not run self-tests either, there's no versioning and that's just the tip of the iceberg... I'm not going to add a 2nd build-system and cmake is not particularly practical for cross-compilation without dedicated handling for it. I'm sorry, this will need further work if this is going to replace autotools. PS. For the same result as the proposed CMakeLists + MSVC, the easiest is to simply copy the liboauth files into the MSVC project (liboauth is very liberally licensed) and compile+link along with the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake support might be interesting for many developers.
Tested on Win 8.1 with Visual Studio 2013.