Skip to content

Upgrade phoenix to 1.6.6 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Upgrade phoenix to 1.6.6 #168

wants to merge 2 commits into from

Conversation

@eldano
Copy link
Contributor

@eldano eldano commented Jan 27, 2022 •
edited
Loading

The upgrade of phoenix to 1.6.6 caused upgrading also phoenix_html which deprecated the sigil ~e used in the history component. This is only a deprecation but we don't merge code with warnings so this needs to be fixed in this PR.
TODO:

  • Rewrite the code that uses the ~e sigil to use a heex template (with the ~H sigil)
  • An issue with this is that spacing in the template code is not reflected the same way as with the ~e sigil on the HTML output, so this needs to be accounted for.

@eldano eldano marked this pull request as draft January 28, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eldano