Switch genome name lookup to hashmap#40
Draft
AroneyS wants to merge 1 commit into
Draft
Conversation
Owner
|
Maybe just use string from |
AroneyS
commented
Nov 30, 2023
| @@ -78,14 +80,8 @@ fn precluster_skani( | |||
| let query_name = sketches[j].file_name.clone(); | |||
Collaborator
Author
There was a problem hiding this comment.
@wwood I tried using String::from(ref_sketch.file_name) and String::from(ref_sketch.file_name.clone()) but get the same error. Did you mean somewhere else?
Owner
|
Something along these lines? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a go, but I can't work out this compiler error: