Skip to content

Sync Relase/ballerina 5.12.x with Release/ballerina 5.12.1#2407

Merged
NipunaRanasinghe merged 9 commits into
wso2:release/ballerina-5.12.xfrom
samithkavishke:release/ballerina-5.12.1
Jul 6, 2026
Merged

Sync Relase/ballerina 5.12.x with Release/ballerina 5.12.1#2407
NipunaRanasinghe merged 9 commits into
wso2:release/ballerina-5.12.xfrom
samithkavishke:release/ballerina-5.12.1

Conversation

@samithkavishke

@samithkavishke samithkavishke commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

UI Component Development

Specify the reason if following are not followed.

  • Added reusable UI components to the ui-toolkit. Follow the intructions when adding the componenent.
  • Use ui-toolkit components wherever possible. Run npm run storybook from the root directory to view current components.
  • Matches with the native VSCode look and feel.

Manage Icons

Specify the reason if following are not followed.

  • Added Icons to the font-wso2-vscode. Follow the instructions.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

  • Bug Fixes

    • Improved workspace navigation reliability, reducing issues when loading project trees and sidebar views.
    • Updated the contact email shown in AI usage-limit messages.
    • Adjusted expression editing behavior to better handle interpolated and plain expressions.
  • Chores

    • Updated dependency version overrides for better compatibility.
    • Bumped the extension version and pinned the test environment version for consistency.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@samithkavishke, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 01047613-f75e-470d-9936-568c404f37a6

📥 Commits

Reviewing files that changed from the base of the PR and between c451358 and c03f684.

⛔ Files ignored due to path filters (2)
  • common/autoinstallers/rush-plugins/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • common/config/rush/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (10)
  • common/autoinstallers/rush-plugins/package.json
  • common/config/rush/pnpm-config.json
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/run-concurrent/run-concurrent.spec.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/run-conflict/run-conflict.spec.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/helpers/setup.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/helpers/sidebar.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/pages/ProjectExplorer.ts
  • workspaces/ballerina/ballerina-extension/package.json
  • workspaces/ballerina/ballerina-extension/src/features/ai/utils/ai-client.ts
  • workspaces/ballerina/ballerina-visualizer/src/views/AIPanel/components/AIChat/index.tsx
📝 Walkthrough

Walkthrough

This PR updates pnpm dependency overrides (undici, plus new entries in globalOverrides), refactors Playwright e2e tests to use a shared tree-item selector helper, adds sidebar activity-tab activation logic, pins the test VS Code version, bumps the extension version, updates quota contact emails, and adjusts orphan-token filtering logic conditional on interpolation.

Changes

Dependency Overrides

Layer / File(s) Summary
Override version updates
common/autoinstallers/rush-plugins/package.json, common/config/rush/pnpm-config.json
Bumps undici pnpm override to 6.27.0 and adds new globalOverrides entries for packages including @babel/core, dompurify, form-data, js-yaml, markdown-it, protobufjs, tmp, webpack-dev-server, undici, and http-proxy-middleware.

Playwright E2E Test Stabilization

Layer / File(s) Summary
Shared tree item selector
.../utils/pages/ProjectExplorer.ts, .../run-concurrent.spec.ts, .../run-conflict.spec.ts
Adds ProjectExplorer.treeItemSelector(label) to build a tolerant aria-label CSS selector, and updates findItem, goToOverview, and two e2e specs to use it instead of hardcoded selectors.
Sidebar activation and version pin
.../utils/helpers/sidebar.ts, .../utils/helpers/setup.ts
Adds activity-tab activation logic to waitForBISidebarTreeView before waiting for the sidebar view, and pins the e2e test harness VS Code version to 1.125.1.

Version, Contact Email, and Expression Editor Fix

Layer / File(s) Summary
Extension version bump
workspaces/ballerina/ballerina-extension/package.json
Bumps the extension version from 5.12.0 to 5.12.1.
Quota contact email update
.../ai-client.ts, .../AIChat/index.tsx
Changes the quota/usage-limit contact email constant to support@wso2.com in both the AI client utility and the AI chat panel UI.
Orphan token filter fix
.../ChipExpressionEditor/CodeUtils.ts
Adds a hasInterpolation flag and restricts orphan-token filtering to only apply when interpolation tokens are present.

Estimated code review effort: 2 (Simple) | ~12 minutes

Possibly related PRs

  • wso2/vscode-extensions#2254: Both PRs update pnpm dependency override configuration, overlapping on protobufjs version resolution.
  • wso2/vscode-extensions#2320: Both PRs modify the orphan-token filtering logic in ChipExpressionEditor/CodeUtils.ts around interpolation ranges.
  • wso2/vscode-extensions#2390: Both PRs bump the pnpm.overrides.undici version in common/autoinstallers/rush-plugins/package.json.

Suggested reviewers: hevayo, gigara

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only repeats the template headings and omits the required filled-in project details. Replace the template text with filled sections for purpose, goals, approach, tests, security checks, release note, and relevant links.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR's main sync and version-bump theme, though it contains a typo.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@samithkavishke samithkavishke force-pushed the release/ballerina-5.12.1 branch from c451358 to c03f684 Compare July 6, 2026 08:26
@samithkavishke samithkavishke added the Checks/Run Ballerina UI Tests Force run Ballerina UI tests label Jul 6, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@common/config/rush/pnpm-config.json`:
- Around line 96-106: The new security overrides in the Rush pnpm config are
still being shadowed by older pins in .pnpmfile.cjs, so update the matching
entries there for js-yaml, dompurify, tmp, and undici to the newer allowed
versions or remove those explicit pins entirely. Check the pnpm override logic
in the .pnpmfile.cjs hooks so the package resolutions for these dependencies can
actually follow the values defined in globalOverrides.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50386f92-6c22-4744-8152-e7e845b25236

📥 Commits

Reviewing files that changed from the base of the PR and between 78deb03 and c451358.

⛔ Files ignored due to path filters (2)
  • common/autoinstallers/rush-plugins/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • common/config/rush/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • common/autoinstallers/rush-plugins/package.json
  • common/config/rush/pnpm-config.json
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/run-concurrent/run-concurrent.spec.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/run-conflict/run-conflict.spec.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/helpers/setup.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/helpers/sidebar.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/pages/ProjectExplorer.ts
  • workspaces/ballerina/ballerina-extension/package.json
  • workspaces/ballerina/ballerina-extension/src/features/ai/utils/ai-client.ts
  • workspaces/ballerina/ballerina-side-panel/src/components/editors/MultiModeExpressionEditor/ChipExpressionEditor/CodeUtils.ts
  • workspaces/ballerina/ballerina-visualizer/src/views/AIPanel/components/AIChat/index.tsx

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@common/config/rush/pnpm-config.json`:
- Around line 96-106: The new security overrides in the Rush pnpm config are
still being shadowed by older pins in .pnpmfile.cjs, so update the matching
entries there for js-yaml, dompurify, tmp, and undici to the newer allowed
versions or remove those explicit pins entirely. Check the pnpm override logic
in the .pnpmfile.cjs hooks so the package resolutions for these dependencies can
actually follow the values defined in globalOverrides.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50386f92-6c22-4744-8152-e7e845b25236

📥 Commits

Reviewing files that changed from the base of the PR and between 78deb03 and c451358.

⛔ Files ignored due to path filters (2)
  • common/autoinstallers/rush-plugins/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • common/config/rush/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • common/autoinstallers/rush-plugins/package.json
  • common/config/rush/pnpm-config.json
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/run-concurrent/run-concurrent.spec.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/run-conflict/run-conflict.spec.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/helpers/setup.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/helpers/sidebar.ts
  • workspaces/ballerina/ballerina-extension/e2e-test/e2e-playwright-tests/utils/pages/ProjectExplorer.ts
  • workspaces/ballerina/ballerina-extension/package.json
  • workspaces/ballerina/ballerina-extension/src/features/ai/utils/ai-client.ts
  • workspaces/ballerina/ballerina-side-panel/src/components/editors/MultiModeExpressionEditor/ChipExpressionEditor/CodeUtils.ts
  • workspaces/ballerina/ballerina-visualizer/src/views/AIPanel/components/AIChat/index.tsx
🛑 Comments failed to post (1)
common/config/rush/pnpm-config.json (1)

96-106: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
rg -n "undici|js-yaml|tmp|dompurify" common/config/rush/.pnpmfile.cjs

Repository: wso2/vscode-extensions

Length of output: 391


Align .pnpmfile.cjs with the new security overrides
globalOverrides won’t take effect for these packages while .pnpmfile.cjs still pins older versions: js-yaml 4.1.1, dompurify 3.4.0, tmp 0.2.6, and undici 7.24.0. Update or remove the matching pins there, or the Trivy fixes here will be overridden.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@common/config/rush/pnpm-config.json` around lines 96 - 106, The new security
overrides in the Rush pnpm config are still being shadowed by older pins in
.pnpmfile.cjs, so update the matching entries there for js-yaml, dompurify, tmp,
and undici to the newer allowed versions or remove those explicit pins entirely.
Check the pnpm override logic in the .pnpmfile.cjs hooks so the package
resolutions for these dependencies can actually follow the values defined in
globalOverrides.

@NipunaRanasinghe NipunaRanasinghe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NipunaRanasinghe NipunaRanasinghe merged commit dacabb2 into wso2:release/ballerina-5.12.x Jul 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checks/Run Ballerina UI Tests Force run Ballerina UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants