Rename inbound-connectors to inbound-endpoints#2400
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis change renames user-facing and internal terminology from "inbound connector" to "inbound endpoint" across the MI core enum label, extension resource directory references, error messages, and visualizer form UI text. ChangesInbound Connector to Inbound Endpoint Rename
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
workspaces/mi/mi-extension/src/rpc-managers/mi-diagram/rpc-manager.ts (1)
4131-4153: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winFinish the terminology rename in the inbound failure path.
The destination path is correct, but this branch still surfaces the old inbound connector wording in the duplicate-name error. That leaves the import flow with mixed terminology.
Fix
- return { success: false, error: `An inbound connector with the name '${path.basename(connectorPath)}' already exists.` }; + return { success: false, error: `An inbound endpoint with the name '${path.basename(connectorPath)}' already exists.` };🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@workspaces/mi/mi-extension/src/rpc-managers/mi-diagram/rpc-manager.ts` around lines 4131 - 4153, The inbound endpoint import path still reports a duplicate using the old “inbound connector” terminology. Update the duplicate-name failure branch in the inbound import flow inside the rpc-manager logic around the inboundDestinationPath check to use consistent “inbound endpoint” wording in the returned error message, matching the rest of the updateInboundConnectors flow and nearby helper naming.workspaces/mi/mi-visualizer/src/views/Forms/InboundEPform/ImportInboundConnector.tsx (1)
95-112: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winFinish the rename in this form’s copy.
The title/selector now say “inbound endpoint”, but the surrounding validation/error text still uses “connector”, so the dialog reads inconsistently.
Fix
- setImportError(response.error || "Error importing inbound connector. Please try again..."); + setImportError(response.error || "Error importing inbound endpoint. Please try again..."); - setImportError("Error importing inbound connector. Please try again..."); + setImportError("Error importing inbound endpoint. Please try again..."); - <ErrorBanner errorMsg={"Please select a connector zip file"} /> + <ErrorBanner errorMsg={"Please select an inbound endpoint zip file"} />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@workspaces/mi/mi-visualizer/src/views/Forms/InboundEPform/ImportInboundConnector.tsx` around lines 95 - 112, The ImportInboundConnector form copy is inconsistent because some validation/error text still says “connector” while the component already uses “inbound endpoint” in the title and selector. Update the remaining user-facing strings in ImportInboundConnector, including the zip-file validation message and any nearby error copy, to consistently use “inbound endpoint” so the dialog wording matches throughout.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@workspaces/mi/mi-visualizer/src/views/Forms/InboundEPform/index.tsx`:
- Line 124: The InboundEPform component still has inconsistent terminology
because some tooltip and download-state strings use “connector” while the
updated error/button text uses “inbound-endpoints”. Update the remaining UI text
in this importer so every user-facing label, tooltip, and loading/download state
in the same component uses the inbound-endpoints terminology consistently, and
verify the related strings near the showNotification call and the other
referenced occurrence are updated together.
---
Outside diff comments:
In `@workspaces/mi/mi-extension/src/rpc-managers/mi-diagram/rpc-manager.ts`:
- Around line 4131-4153: The inbound endpoint import path still reports a
duplicate using the old “inbound connector” terminology. Update the
duplicate-name failure branch in the inbound import flow inside the rpc-manager
logic around the inboundDestinationPath check to use consistent “inbound
endpoint” wording in the returned error message, matching the rest of the
updateInboundConnectors flow and nearby helper naming.
In
`@workspaces/mi/mi-visualizer/src/views/Forms/InboundEPform/ImportInboundConnector.tsx`:
- Around line 95-112: The ImportInboundConnector form copy is inconsistent
because some validation/error text still says “connector” while the component
already uses “inbound endpoint” in the title and selector. Update the remaining
user-facing strings in ImportInboundConnector, including the zip-file validation
message and any nearby error copy, to consistently use “inbound endpoint” so the
dialog wording matches throughout.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: aee8e35f-ac43-4552-bcfa-439b24cab42d
📒 Files selected for processing (5)
workspaces/mi/mi-core/src/state-machine-types.tsworkspaces/mi/mi-extension/src/ai-features/agent-mode/tools/connector_ls_client.tsworkspaces/mi/mi-extension/src/rpc-managers/mi-diagram/rpc-manager.tsworkspaces/mi/mi-visualizer/src/views/Forms/InboundEPform/ImportInboundConnector.tsxworkspaces/mi/mi-visualizer/src/views/Forms/InboundEPform/index.tsx
ChinthakaJ98
force-pushed
the
inbound-dir-change
branch
from
ad0ba10 to
969ada7
Compare
ChinthakaJ98
force-pushed
the
inbound-dir-change
branch
from
969ada7 to
3f30e8e
Compare
2 participants
$subject
Summary by CodeRabbit
Bug Fixes
Style