Fix issues in the MI Extension - #1568
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/mi-extension/src/project-explorer/project-explorer-provider.ts`:
- Around line 219-223: In the hasPom branch of the project explorer provider,
replace buildReadOnlyFileEntry for pomPath with the standard editable file-entry
builder so pom.xml is editable and does not receive the readOnlyFile context.
Keep buildReadOnlyFolderChildren unchanged so the docker-build folder remains
read-only.
In `@packages/mi-extension/src/util/onboardingUtils.ts`:
- Around line 806-813: Update the updatePomXml call guarded by
hasSynapseCoreDependency to match both groupId org.apache.synapse and artifactId
synapse-core before selecting version. Preserve the existing synapseCoreVersion
update while preventing dependencies with the same artifactId from other groups
from being modified.
In `@packages/mi-extension/src/util/templates.ts`:
- Around line 496-507: Update libLineRegex in the existing-content parsing flow
to accept one or more whitespace characters between COPY, the library path, and
${WSO2_SERVER_HOME}, while preserving the matched original line in
existingLibLines. Add regression coverage for multiple spaces and tab-separated
valid COPY directives to ensure libsCopyLines reuses them instead of emitting
commented defaults.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 258d078d-5b7e-4f45-9f9e-556bbc5e7c13
📒 Files selected for processing (5)
packages/mi-extension/src/debugger/pomResolver.tspackages/mi-extension/src/project-explorer/project-explorer-provider.tspackages/mi-extension/src/stateMachine.tspackages/mi-extension/src/util/onboardingUtils.tspackages/mi-extension/src/util/templates.ts
This PR will fix the below mentioned issues.