Skip to content

Remove the duplicate Resources page from Settings - #626

Merged
xlight05 merged 2 commits into
mainfrom
marketplace/09-settings
Aug 26, 2026
Merged

Remove the duplicate Resources page from Settings#626
xlight05 merged 2 commits into
mainfrom
marketplace/09-settings

Conversation

@kaje94

@kaje94 kaje94 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Why this exists

The console used to show org resources in two places:

  1. Settings → Resources (/settings/resources) — the old buried catalog (platform types vs external, in two tabs).
  2. Resources in the org sidebar (/resources) — the Marketplace catalog added earlier on this stack, where people actually discover types, register a third-party API, and edit it.

Two catalogs for the same data is confusing. This PR removes the Settings one so there is a single place: Resources in the org sidebar.

What you will see

Settings. The Settings rail is Credentials, Skills, and Usage only. There is no Resources tab. GitHub/Anthropic keys, the skills catalogue, and usage are unchanged.

Old URL. /settings/resources is a 404 (“Page not found”). It does not redirect to /resources. Bookmarks and old links fail loudly instead of silently landing on the new page.

Where to go instead. Org members browse Platform resource types and External resources at /resources. Registering a new External resource is still Register on that page (/resources/register).

What this PR does not change

  • It does not move or rebuild the /resources catalog, register flow, or edit/docs/chat/consume layers (those shipped on earlier PRs in this stack).
  • It does not remove Settings as a whole.
  • It does not change Endpoints or Project Overview (those are other stacks).

How to verify

  • Open Settings: tabs are Credentials, Skills, Usage — no Resources.
  • Visit /settings/resources: URL stays /settings/resources and the page is Page not found, not the catalog.
  • Open Resources in the org sidebar: the catalog still lists types and Register still opens /resources/register.

Covered in console tests:

  • Settings layout has no Resources item; Credentials / Skills / Usage remain
  • /settings/resources is not a registered route (so it cannot be a page or a redirect)
  • Full @aep/console vitest suite + typecheck

Stack

Last layer on the Resources stack. Base is marketplace/08-consume (#625), not main. Merge with gh stack merge 626 --yes, not gh pr merge.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a04dbe9a-ac4d-4d81-be87-4330aad7e330

📥 Commits

Reviewing files that changed from the base of the PR and between 86c1155 and 11f974a.

📒 Files selected for processing (10)
  • apps/console/src/features/projects/components/OverviewDependencies.test.tsx
  • apps/console/src/features/projects/components/OverviewDependencies.tsx
  • apps/console/src/features/settings/components/ResourceDrawer.test.tsx
  • apps/console/src/features/settings/components/ResourceDrawer.tsx
  • apps/console/src/features/settings/components/ResourcesSection.test.tsx
  • apps/console/src/features/settings/components/ResourcesSection.tsx
  • apps/console/src/features/settings/components/SettingsLayout.test.tsx
  • apps/console/src/features/settings/components/SettingsLayout.tsx
  • apps/console/src/routes/settings.resources.absent.test.ts
  • apps/console/src/routes/settings.resources.tsx

Comment @coderabbitai help to get the list of available commands.

@kaje94 kaje94 changed the title feat: retire Settings → Resources so the catalog lives only at /resources 09 — Retire Settings → Resources Aug 25, 2026
@kaje94
kaje94 force-pushed the marketplace/09-settings branch from 313db86 to 16a8b6e Compare August 25, 2026 13:33
@kaje94 kaje94 changed the title 09 — Retire Settings → Resources Remove the duplicate Resources page from Settings Aug 25, 2026
@kaje94
kaje94 marked this pull request as ready for review August 25, 2026 13:43
@kaje94
kaje94 force-pushed the marketplace/09-settings branch from 16a8b6e to a039bff Compare August 25, 2026 13:53
@kaje94
kaje94 force-pushed the marketplace/09-settings branch 2 times, most recently from 837d0c4 to 733bfec Compare August 26, 2026 00:04
@kaje94
kaje94 force-pushed the marketplace/09-settings branch from 733bfec to 3554991 Compare August 26, 2026 15:40
@kaje94
kaje94 force-pushed the marketplace/09-settings branch from 3554991 to 6c5cbc2 Compare August 26, 2026 15:55
@xlight05
xlight05 force-pushed the marketplace/09-settings branch from 6c5cbc2 to 5b4c68a Compare August 26, 2026 16:45
@xlight05
xlight05 force-pushed the marketplace/09-settings branch from 5b4c68a to f0fbd03 Compare August 26, 2026 16:46
@xlight05
xlight05 force-pushed the marketplace/09-settings branch from f0fbd03 to 1979a5c Compare August 26, 2026 16:46
@xlight05
xlight05 force-pushed the marketplace/09-settings branch from 1979a5c to 694b078 Compare August 26, 2026 16:47
@xlight05
xlight05 force-pushed the marketplace/09-settings branch from 694b078 to ac36c01 Compare August 26, 2026 16:48
Base automatically changed from marketplace/08-consume to main August 26, 2026 16:50
kaje94 added 2 commits August 26, 2026 22:20
Settings retirement deleted ResourceDrawer; Overview (already on main) still imported it, which broke console typecheck.
@xlight05
xlight05 force-pushed the marketplace/09-settings branch from ac36c01 to 11f974a Compare August 26, 2026 16:50
@xlight05
xlight05 merged commit d64a81f into main Aug 26, 2026
2 checks passed
axewilledge added a commit that referenced this pull request Aug 27, 2026
…findings

**Conflict** was one hunk in `PRD.md`: both sides added an entry at the head of
the feature inventory. Both belong; kept both, this one first since it ships
after #636.

**ADR renumbered 0020 -> 0021.** Upstream landed its own ADR-0020 (the console
never creates document nodes) while this branch was open. Every cross-reference
follows. Worth saying plainly: my first pass at the rename was a blanket regex
that also rewrote THREE upstream files which legitimately cite ADR-0020 — its
own heading, `useCollabSpec.ts` and its test. Reverted those to upstream and
redid the rename precisely.

**`/settings/resources` -> `/resources`.** Upstream moved the resources catalog
out of Settings (#626), which broke the blocked task row's "Configure in
Resources" link. Caught by the typecheck, not by a test — the route union is
what makes that impossible to miss.

**Two review findings that were still open, both real:**

- The `building` scenario answered `/builds/v3/runs` with an envelope tagged
  `v3` carrying `run-v1-1` at milestone 1 — a fixture contradicting itself, and
  exactly the kind of thing that stops a mock being evidence. `buildRunsForTag`
  now stamps the run's identity from the tag actually asked for, and answers an
  empty run list for a version the scenario never built, as the real server does.
- The routing half of ADR-0021 §8 had no tests, and it is the part of this
  feature most likely to break silently: it is a URL contract. Eleven now cover
  the `?tag=` redirect and its `replace`, the numeric-segment redirect into
  `/tasks/$issueNumber`, that a version tag is NOT treated as an issue number,
  that `0`/`-3`/`1.5`/`12abc` are not either, and the task route's own parse and
  round-trip. `redirect()` throws a `Response` with the options on `.options`,
  so the helper reads what the router will actually act on rather than a shape
  that happens to pass.

1405 tests / 120 files green; tsc and eslint clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants