Remove the duplicate Resources page from Settings - #626
Merged
Conversation
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Comment |
kaje94
force-pushed
the
marketplace/09-settings
branch
from
August 25, 2026 13:33
313db86 to
16a8b6e
Compare
kaje94
marked this pull request as ready for review
August 25, 2026 13:43
kaje94
force-pushed
the
marketplace/09-settings
branch
from
August 25, 2026 13:53
16a8b6e to
a039bff
Compare
kaje94
force-pushed
the
marketplace/09-settings
branch
2 times, most recently
from
August 26, 2026 00:04
837d0c4 to
733bfec
Compare
kaje94
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 15:40
733bfec to
3554991
Compare
kaje94
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 15:55
3554991 to
6c5cbc2
Compare
xlight05
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 16:45
6c5cbc2 to
5b4c68a
Compare
xlight05
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 16:46
5b4c68a to
f0fbd03
Compare
xlight05
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 16:46
f0fbd03 to
1979a5c
Compare
xlight05
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 16:47
1979a5c to
694b078
Compare
xlight05
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 16:48
694b078 to
ac36c01
Compare
xlight05
approved these changes
Aug 26, 2026
Settings retirement deleted ResourceDrawer; Overview (already on main) still imported it, which broke console typecheck.
xlight05
force-pushed
the
marketplace/09-settings
branch
from
August 26, 2026 16:50
ac36c01 to
11f974a
Compare
axewilledge
added a commit
that referenced
this pull request
Aug 27, 2026
…findings **Conflict** was one hunk in `PRD.md`: both sides added an entry at the head of the feature inventory. Both belong; kept both, this one first since it ships after #636. **ADR renumbered 0020 -> 0021.** Upstream landed its own ADR-0020 (the console never creates document nodes) while this branch was open. Every cross-reference follows. Worth saying plainly: my first pass at the rename was a blanket regex that also rewrote THREE upstream files which legitimately cite ADR-0020 — its own heading, `useCollabSpec.ts` and its test. Reverted those to upstream and redid the rename precisely. **`/settings/resources` -> `/resources`.** Upstream moved the resources catalog out of Settings (#626), which broke the blocked task row's "Configure in Resources" link. Caught by the typecheck, not by a test — the route union is what makes that impossible to miss. **Two review findings that were still open, both real:** - The `building` scenario answered `/builds/v3/runs` with an envelope tagged `v3` carrying `run-v1-1` at milestone 1 — a fixture contradicting itself, and exactly the kind of thing that stops a mock being evidence. `buildRunsForTag` now stamps the run's identity from the tag actually asked for, and answers an empty run list for a version the scenario never built, as the real server does. - The routing half of ADR-0021 §8 had no tests, and it is the part of this feature most likely to break silently: it is a URL contract. Eleven now cover the `?tag=` redirect and its `replace`, the numeric-segment redirect into `/tasks/$issueNumber`, that a version tag is NOT treated as an issue number, that `0`/`-3`/`1.5`/`12abc` are not either, and the task route's own parse and round-trip. `redirect()` throws a `Response` with the options on `.options`, so the helper reads what the router will actually act on rather than a shape that happens to pass. 1405 tests / 120 files green; tsc and eslint clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this exists
The console used to show org resources in two places:
/settings/resources) — the old buried catalog (platform types vs external, in two tabs)./resources) — the Marketplace catalog added earlier on this stack, where people actually discover types, register a third-party API, and edit it.Two catalogs for the same data is confusing. This PR removes the Settings one so there is a single place: Resources in the org sidebar.
What you will see
Settings. The Settings rail is Credentials, Skills, and Usage only. There is no Resources tab. GitHub/Anthropic keys, the skills catalogue, and usage are unchanged.
Old URL.
/settings/resourcesis a 404 (“Page not found”). It does not redirect to/resources. Bookmarks and old links fail loudly instead of silently landing on the new page.Where to go instead. Org members browse Platform resource types and External resources at
/resources. Registering a new External resource is still Register on that page (/resources/register).What this PR does not change
/resourcescatalog, register flow, or edit/docs/chat/consume layers (those shipped on earlier PRs in this stack).How to verify
/settings/resources: URL stays/settings/resourcesand the page is Page not found, not the catalog./resources/register.Covered in console tests:
/settings/resourcesis not a registered route (so it cannot be a page or a redirect)@aep/consolevitest suite + typecheckStack
Last layer on the Resources stack. Base is
marketplace/08-consume(#625), notmain. Merge withgh stack merge 626 --yes, notgh pr merge.