Skip to content

Revert "fix(remote-worker): pin playwright-cli to the baked chromium, and stop baking browsers it cannot launch" - #598

Merged
KCSAbeywickrama merged 1 commit into
mainfrom
revert-571-validation-14
Aug 22, 2026
Merged

Revert "fix(remote-worker): pin playwright-cli to the baked chromium, and stop baking browsers it cannot launch"#598
KCSAbeywickrama merged 1 commit into
mainfrom
revert-571-validation-14

Conversation

@KCSAbeywickrama

Copy link
Copy Markdown
Contributor

Reverts #571

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9351bde8-531c-455c-8fcc-a8d64131f7af

📥 Commits

Reviewing files that changed from the base of the PR and between 728dafb and e519167.

📒 Files selected for processing (2)
  • runners/remote-worker/Dockerfile
  • runners/remote-worker/design/decisions/ADR-0007-the-runner-image-names-the-cli-browser.md
💤 Files with no reviewable changes (1)
  • runners/remote-worker/design/decisions/ADR-0007-the-runner-image-names-the-cli-browser.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary

  • Revert the remote worker’s fixed Chromium browser configuration.
  • Allow playwright-cli install-browser to use its default browser selection.
  • Remove the PLAYWRIGHT_MCP_BROWSER=chromium environment variable.
  • Delete ADR-0007, which documented the reverted configuration.

Walkthrough

The remote-worker image no longer sets PLAYWRIGHT_MCP_BROWSER=chromium. Its secondary Playwright browser installation now uses the CLI default and retains non-fatal error handling. The ADR that documented the explicit Chromium configuration was deleted.

Suggested reviewers: xlight05

Merge Risk: 🔵 Low · up to e5191

The image build may provision Chromium while the command-line browser selection follows a different default before task configuration is available, which could leave implementation or validation tasks without the browser they need at runtime. The PR is mergeable with explicit owner confirmation that browser selection remains aligned for both task modes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies this change as a revert of the Playwright remote-worker fix.
Description check ✅ Passed The description states that the pull request reverts issue #571, which matches the documented changes and objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-571-validation-14

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KCSAbeywickrama
KCSAbeywickrama merged commit 6fa219f into main Aug 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants