fix(platform-chart): add observability-alert-rule to web-application ComponentType allowedTraits - #591
Conversation
…ComponentType allowedTraits deployment_spec.go attaches the observability-alert-rule ClusterTrait to all deployment components (service and web-application) when ResolveAutoRCAEnabled is true. Without this trait in the ComponentType's allowedTraits list, OC rejects release generation with: traits [ClusterTrait:observability-alert-rule] are not in the allowed list [] Live cluster fix: kubectl patch applied to web-application ComponentType. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughSummary
WalkthroughThe web-application Merge Risk: ⚪ Minimal · up to This change allows web-application components to use the observability alert trait they already receive during deployment. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
deployment_spec.goattaches theobservability-alert-ruleClusterTrait to all deployment components (serviceandweb-application) whenResolveAutoRCAEnabledis true (seealert_rule_trait.go:DesiredObservabilityAlertRuleTraits)web-applicationComponentType had noallowedTraitsfield at all, so OC rejected release generation for every webapp component with:traits [ClusterTrait:observability-alert-rule] are not in the allowed list []service), just for theweb-applicationComponentTypeobservability-alert-ruleis needed (noapi-configuration)Proof
Live cluster blocked with this error (expense-webapp in mm1):
Live fix applied:
kubectl patch componenttype web-application -n default --type=merge \ -p '{"spec":{"allowedTraits":[{"kind":"ClusterTrait","name":"observability-alert-rule"}]}}'componenttype.openchoreo.dev/web-application patched ✓
Related
serviceComponentType: fix(platform-chart): add observability-alert-rule to service ComponentType allowedTraits #590