[Devant migration] Fix cloud build by adding client call mocks#753
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe APIM API contract now includes overview, thumbnail, and marketplace service operations. The cloud implementation provides typed safe-default and no-op stubs for these operations. The ICP implementation exposes corresponding stubs that delegate to the existing not-implemented helper. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ipaas/src/api/cloud/apim.ts`:
- Around line 66-88: Update fetchApimOverview, saveApimOverview,
fetchApimThumbnail, saveApimThumbnail, fetchMarketplaceService, and
saveMarketplaceService to delegate to ni() with each operation’s function name.
Remove fabricated return values and silent no-op saves so every unsupported
cloud operation throws through the existing stub behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c354ef80-f84e-4cda-84c8-d9587cecdd79
📒 Files selected for processing (3)
ipaas/src/api/cloud/apim.tsipaas/src/api/contracts.tsipaas/src/api/icp/apim.ts
Purpose
Add mock client calls to fix cloud variant build failure
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning