Skip to content

Add asgardeo notification settings page - #6327

Open
Miranlfk wants to merge 2 commits into
wso2:masterfrom
Miranlfk:add-asgardeo-notification-settings-page
Open

Add asgardeo notification settings page#6327
Miranlfk wants to merge 2 commits into
wso2:masterfrom
Miranlfk:add-asgardeo-notification-settings-page

Conversation

@Miranlfk

@Miranlfk Miranlfk commented Sep 4, 2026

Copy link
Copy Markdown
Member

Purpose

$subject

… site

The Internal Notification Sending tile in the Console (Login & Registration >
Notification Settings) had no Learn More link, because the page it should point
to is only published on the Identity Server site.

The content already exists and is product-neutral:
en/includes/guides/account-configurations/notification-settings.md. This adds
the stub, nav entry and screenshot needed to publish it on this site as well, so
the page resolves at
/guides/account-configurations/notification-settings/.

Related console fix: wso2/identity-apps#10659
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Team

Run ID: 743c67af-7597-42f1-b900-9bcc0561843e

📥 Commits

Reviewing files that changed from the base of the PR and between 41ef00a and b95fef3.

⛔ Files ignored due to path filters (1)
  • en/asgardeo/docs/assets/img/guides/account-configurations/notification-sending.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • en/asgardeo/docs/guides/account-configurations/notification-settings.md
  • en/asgardeo/mkdocs.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Asgardeo documentation adds a notification settings page that renders shared content and appears under Account configurations in the navigation.

Changes

Notification settings documentation

Layer / File(s) Summary
Add notification settings documentation
en/asgardeo/docs/guides/account-configurations/notification-settings.md, en/asgardeo/mkdocs.yml
The new page includes shared notification settings content. The MkDocs navigation links to the page under Account configurations.

Suggested labels: Team/Identity Server Core

Suggested reviewers: pavindulakshan, kd23243

Merge Risk: ⚪ Minimal · up to b95fe

This adds the Notification settings documentation page and navigation link. The page target and shared guide inclusion are aligned, with no current merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the Purpose heading but contains only the placeholder "$subject". It omits Related PRs, Test environment, and the required Security checks. Replace "$subject" with a specific purpose statement. Add the Related PRs and Test environment sections. Complete all Security checks items and include issue links when applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding the Asgardeo notification settings page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants