Document flow extension attribute access and supported flows - #6295
Document flow extension attribute access and supported flows#6295KD23243 wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughChangesFlow extension API schemas now support three flow types. Configuration and guides document protected write paths, attribute access behavior, reusable external service endpoints, and operation validation rules. Flow extension updates
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@en/asgardeo/docs/apis/restapis/flow-extension-management.yaml`:
- Around line 584-588: Update the modify property description in the
flow-extension management API schema to clarify that configuring a
non-modifiable path is rejected with a 400 response, while runtime response
operations targeting such paths are skipped and remaining operations continue.
In `@en/includes/guides/flows/flow-extension-configuration.md`:
- Around line 85-91: Update the introductory sentence before the access table to
avoid calling all listed rows “exceptions.” Use wording that accurately covers
unavailable controls alongside attributes with flow-specific behavior or usage
guidance, while leaving the table entries unchanged.
- Around line 95-97: Update the note associated with
actions.types.flow_extension.non_modifiable_paths to use active voice and state
precisely that this property defines the paths that cannot be modified, rather
than saying it sets read-only attributes. Preserve the existing
configuration-catalog reference.
In `@en/includes/guides/flows/flow-extensions/index.md`:
- Line 37: Update the sentence in the flow extensions guide to replace the vague
phrase “a small number of attributes” with “some attributes” or the contract’s
exact attribute count, while leaving the surrounding explanation and link
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: 49a01d61-c5d7-4969-bd3e-eff92b76f856
⛔ Files ignored due to path filters (3)
en/identity-server/next/docs/assets/img/guides/flows/flow-extension-encryption-certificate.mp4is excluded by!**/*.mp4en/identity-server/next/docs/assets/img/guides/flows/flow-extension-encryption-settings.pngis excluded by!**/*.pngen/identity-server/next/docs/assets/img/guides/flows/flow-extension-encryption-toggles.pngis excluded by!**/*.png
📒 Files selected for processing (7)
en/asgardeo/docs/apis/restapis/flow-extension-management.yamlen/asgardeo/docs/references/service-extensions/in-flow-extensions/flow-extension/api/flow-extension-action-v1.yamlen/identity-server/next/docs/_data/configuration_catalog.yamlen/identity-server/next/docs/references/service-extensions/in-flow-extensions/flow-extension/api/flow-extension-action-v1.yamlen/includes/guides/flows/flow-extension-configuration.mden/includes/guides/flows/flow-extension-external-service.mden/includes/guides/flows/flow-extensions/index.md
Purpose
Documents the changes introduced by wso2/carbon-identity-framework#8221 and wso2/identity-apps#10567, and brings the flow extension docs in line with wso2/identity-apps#10537.
Three statements in the existing docs were no longer accurate:
http://wso2.org/claims/identity/*) were documented as impossible for an extension to modify. That restriction has been removed, and these attributes are now listed in the claim picker and support both read and write.Steps 1 and 4 of the configuration guide also rendered with broken media on the IS
nextsite, because three assets referenced by the shared include existed only in the Asgardeo tree.Related Issue
Implementation
Supported flows
flow-extensions/index.mdreplaces the Self-Registration-only note with a Supported flows table covering Self Registration, Password Recovery, and Invited User Registration, along with the flow type each one sends. A new What an extension can read and write section establishes the read and write access model once, and notes that a reused extension can receive a smaller payload in one flow than in another.flow-extension-configuration.mdStep 5 now states the three flows and that the procedure is identical in each, then keeps the Self Registration walkthrough as the worked example.Attribute access levels
flow-extension-configuration.mdStep 3 gains an Attribute access levels section: a table covering fields that accept read only, the username, and identity attributes, plus the error returned when a read-only path is marked as writable through the Flow Extension Management API. The read-only row is identified by the Read-Only badge shown in the Console rather than by specific attributes, since the list is resolved from server configuration.flow-extension-external-service.mddescribes the same rules from the endpoint author's side: the intro notes one service can back more than one flow,flowTypelists its three values, theallowedOperationsguidance explains that the whitelist reflects the current flow, and the operation validation list drops the identity attribute clause in favour of the current rules.Configuration reference
configuration_catalog.yamladds anactions.types.flow_extensionsection documentingnon_modifiable_paths, alongside the existingactionssection and taggedconfigure-actions. This is IS-only, so the property is documented in a file that Asgardeo does not render; the configuration guide carries a single gated pointer to it.API contracts
Both copies of
flow-extension-action-v1.yamlgain aflowTypeenum of the three flow types and note that the username is sent only in the registration flow. The Flow Extension Management API documents that non-modifiable paths onaccessConfig.modifyare rejected.Media
Copies
flow-extension-encryption-certificate.mp4,flow-extension-encryption-settings.png, andflow-extension-encryption-toggles.pnginto the ISnextasset tree, matching the existing convention where each product tree carries its own identical copy. Removes the staleTODOnext to the encryption toggles image, which the image already satisfies; the certificate managementTODOis left in place, as that screenshot shows the upload state rather than a configured certificate.Verification
mkdocs buildfor bothen/identity-server/nextanden/asgardeocompletes with no errors.en/includes/guides/flows/resolve in both trees, and a scan of the built ISnextsite reports no broken asset references on any Flows page.