Skip to content

Clarify branding inheritance behavior after customization - #6293

Merged
pavinduLakshan merged 2 commits into
wso2:masterfrom
pavinduLakshan:docs/clarify-branding-inheritance-behavior
Jul 30, 2026
Merged

Clarify branding inheritance behavior after customization#6293
pavinduLakshan merged 2 commits into
wso2:masterfrom
pavinduLakshan:docs/clarify-branding-inheritance-behavior

Conversation

@pavinduLakshan

@pavinduLakshan pavinduLakshan commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • There is confusion about whether UI branding "inheritance" implies live propagation of parent branding changes, similar to OOP inheritance.
  • The actual behavior: once an organization customizes its own branding (organization-wide or application-specific), it stops inheriting from ancestors — later changes made at an ancestor level are not propagated to it until it reverts to inherited values.
  • This adds an explicit note under both the organization-wide and application-specific branding sections clarifying this behavior, since it was previously only implied by the "nearest ancestor with custom settings" resolution rule.

Explicitly document that once an organization customizes its branding
(organization-wide or application-specific), it stops picking up
subsequent branding changes made by ancestor organizations, until it
reverts to inherited values. Addresses customer confusion about
whether "inheritance" implies live propagation of parent changes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: acbb03c8-9f6a-4952-a7f9-12b8ecc21442

📥 Commits

Reviewing files that changed from the base of the PR and between d3a0576 and 56a9d66.

📒 Files selected for processing (1)
  • en/includes/guides/organization-management/inheritance-in-organizations/ui-branding-inheritance.md

📝 Walkthrough

Walkthrough

Changes

Branding inheritance documentation

Layer / File(s) Summary
Document customization and reversion behavior
en/includes/guides/organization-management/inheritance-in-organizations/ui-branding-inheritance.md
Notes clarify that organization-wide and application-specific branding stop inheriting ancestor changes after customization and resume inheritance after reversion.

Suggested labels: Team/B2B

Suggested reviewers: bimsarabodaragama

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description has a summary, but it omits required template sections for Purpose, Related PRs, Test environment, and Security checks. Add the missing template sections, including purpose with issue links, related PRs, test environment details, and the security checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: clarifying branding inheritance behavior after customization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@en/includes/guides/organization-management/inheritance-in-organizations/ui-branding-inheritance.md`:
- Around line 42-44: Update the “Customized branding does not track later
ancestor changes” note to describe the application-specific reversion order
accurately: after reverting, use the organization’s own organization-wide
branding when available, and otherwise inherit from the nearest ancestor with
custom settings. Preserve the existing explanation that customized
application-specific branding ignores later ancestor changes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 11a07de4-63a6-43f3-b9ae-96acdeb108a0

📥 Commits

Reviewing files that changed from the base of the PR and between 8eea907 and d3a0576.

📒 Files selected for processing (1)
  • en/includes/guides/organization-management/inheritance-in-organizations/ui-branding-inheritance.md

@pavinduLakshan
pavinduLakshan merged commit 7d073b0 into wso2:master Jul 30, 2026
3 of 5 checks passed
@coderabbitai
coderabbitai Bot requested a review from BimsaraBodaragama July 30, 2026 06:17
@pavinduLakshan
pavinduLakshan deleted the docs/clarify-branding-inheritance-behavior branch July 30, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants