-
Notifications
You must be signed in to change notification settings - Fork 197
Fix UI freeze and timestamp format in Usage Report (Issue #4787) #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kavindu21123
wants to merge
1
commit into
wso2:main
Choose a base branch
from
Kavindu21123:fix-usage-report-bug-4787
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In JavaScript Promises, what happens when an error is thrown inside catch() and the resulting Promise is not awaited or otherwise handled?💡 Result:
If you
throwinside a.catch()handler, the promise returned by that.catch()becomes rejected with the thrown error (equivalent to returning a rejected promise). [1]If you then don’t
awaitit or attach another rejection handler (e.g. another.catch()), it becomes an unhandled promise rejection:unhandledrejectionevent fires, and if it isn’t handled, you’ll typically see an error logged to the console. [2]--unhandled-rejections=throw, the default since Node 15), Node emitsunhandledRejection, and if you don’t handle that event, it raises it as an uncaught exception (which commonly terminates the process). [3]Sources: [1] MDN Promise.prototype.catch() (www-igm.univ-mlv.fr), [2] MDN
unhandledrejectionevent (developer.mozilla.org), [3] Node.js CLI--unhandled-rejectionsdocs (nodejs.org)Citations:
🏁 Script executed:
Repository: wso2/apim-apps
Length of output: 1166
Remove the rethrow in this
catchblock to prevent unhandled Promise rejections.The promise chain from
api.getTransactionCount()(line 246) is not awaited or returned byfetchTransactionData(). WhenuseEffectcallsfetchTransactionData()at line 264 without awaiting, the promise becomes unhandled. Rethrowing in thecatchblock at line 255 creates a rejected promise that has no handler, resulting in an unhandled rejection error at runtime.Since the error is already logged, simply removing the
throwallows the promise to resolve, preventing the unhandled rejection while preserving the error logging and thefinallyblock execution.Proposed fix
.catch((error) => { console.error('Error fetching transaction count:', error); - throw error; })📝 Committable suggestion
🤖 Prompt for AI Agents