Change the gw-api conformance cronjob schedule time#2742
Conversation
📝 WalkthroughWalkthroughThe weekly Kubernetes Gateway API conformance workflow now runs at 00:37 UTC on Saturdays. Comments document Friday-change coverage and the off-the-hour schedule rationale. ChangesConformance workflow scheduling
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/k8s-gateway-api-conformance.yml (1)
13-16: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winQualify the scheduling guarantee.
GitHub documents that off-the-hour scheduling reduces the chance of delays or dropped runs; it does not guarantee that
:37will fire reliably. Replace “far more likely” and “reliably fires” with wording such as “reduces the chance of delay or dropping under load.” (docs.github.com)Also applies to: 31-32
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/k8s-gateway-api-conformance.yml around lines 13 - 16, Update the scheduling note near the cron configuration to avoid implying that using an odd minute guarantees reliable execution. Replace “far more likely to actually fire” and any equivalent “reliably fires” wording with qualified language stating that off-the-hour scheduling reduces the chance of delays or dropped runs under load.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/k8s-gateway-api-conformance.yml:
- Around line 13-16: Update the scheduling note near the cron configuration to
avoid implying that using an odd minute guarantees reliable execution. Replace
“far more likely to actually fire” and any equivalent “reliably fires” wording
with qualified language stating that off-the-hour scheduling reduces the chance
of delays or dropped runs under load.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fbb0a794-92a1-4f37-bca9-2b44d2de00ab
📒 Files selected for processing (1)
.github/workflows/k8s-gateway-api-conformance.yml
Purpose