Skip to content

Change the gw-api conformance cronjob schedule time#2742

Closed
O-sura wants to merge 1 commit into
wso2:mainfrom
O-sura:main
Closed

Change the gw-api conformance cronjob schedule time#2742
O-sura wants to merge 1 commit into
wso2:mainfrom
O-sura:main

Conversation

@O-sura

@O-sura O-sura commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Purpose

$subject

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The weekly Kubernetes Gateway API conformance workflow now runs at 00:37 UTC on Saturdays. Comments document Friday-change coverage and the off-the-hour schedule rationale.

Changes

Conformance workflow scheduling

Layer / File(s) Summary
Weekly schedule timing and documentation
.github/workflows/k8s-gateway-api-conformance.yml
The Saturday cron schedule changed from 00:00 UTC to 00:37 UTC, with comments updated to explain Friday coverage and GitHub’s handling of on-the-hour runs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: rakhitharr, tharsanan1, tharindu1st

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains a placeholder Purpose section and omits the required Goals, Approach, tests, docs, and other template sections. Fill out the full template with purpose, goals, approach, user stories, docs, automation tests, security checks, samples, related PRs, and test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adjusting the gw-api conformance cron schedule.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/k8s-gateway-api-conformance.yml (1)

13-16: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Qualify the scheduling guarantee.

GitHub documents that off-the-hour scheduling reduces the chance of delays or dropped runs; it does not guarantee that :37 will fire reliably. Replace “far more likely” and “reliably fires” with wording such as “reduces the chance of delay or dropping under load.” (docs.github.com)

Also applies to: 31-32

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/k8s-gateway-api-conformance.yml around lines 13 - 16,
Update the scheduling note near the cron configuration to avoid implying that
using an odd minute guarantees reliable execution. Replace “far more likely to
actually fire” and any equivalent “reliably fires” wording with qualified
language stating that off-the-hour scheduling reduces the chance of delays or
dropped runs under load.

Source: MCP tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/k8s-gateway-api-conformance.yml:
- Around line 13-16: Update the scheduling note near the cron configuration to
avoid implying that using an odd minute guarantees reliable execution. Replace
“far more likely to actually fire” and any equivalent “reliably fires” wording
with qualified language stating that off-the-hour scheduling reduces the chance
of delays or dropped runs under load.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fbb0a794-92a1-4f37-bca9-2b44d2de00ab

📥 Commits

Reviewing files that changed from the base of the PR and between db88a9d and 6778ba0.

📒 Files selected for processing (1)
  • .github/workflows/k8s-gateway-api-conformance.yml

@O-sura O-sura closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant