Skip to content

Add openchoreo secret manager implementation #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanzjk wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add openchoreo secret manager implementation #1327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0500f01
Add openchoreo secret manager implementation
hanzjk Jul 15, 2026
d26c4d3
Merge remote-tracking branch 'upstream/main' into build-status-enum
hanzjk Jul 15, 2026
78c0142
Add mock clients
hanzjk Jul 15, 2026
e6c7d46
Remove merge-patch encodings
hanzjk Jul 15, 2026
48fdee2
Restore config.js to upstream state
hanzjk Jul 15, 2026
ae1ec29
FIx secret reference sharing across environments
hanzjk Jul 16, 2026
14dc594
Merge remote-tracking branch 'upstream/main' into build-status-enum
hanzjk Jul 16, 2026
ffa8d81
Add missing function implementation
hanzjk Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions agent-manager-service/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,15 @@ OPEN_CHOREO_BASE_URL=http://api.openchoreo.localhost:8195
# API_PLATFORM_ENABLED=false

# -----------------------------------------------------------------------------
# Secret Management Service Configuration (Data Plane)
# Secret Management Service Configuration (via OpenChoreo secret API)
# -----------------------------------------------------------------------------
# SECRET_MANAGER_PROVIDER=openchoreo
# SECRET_MANAGER_TARGET_PLANE_KIND=ClusterDataPlane
# SECRET_MANAGER_TARGET_PLANE_NAME=default

# -----------------------------------------------------------------------------
# OpenBao Configuration (AgentID Thunder provisioning only)
# -----------------------------------------------------------------------------
# SECRET_MANAGER_PROVIDER=openbao
# OPENBAO_URL=http://localhost:8200
# OPENBAO_TOKEN=<your-openbao-token>
# OPENBAO_PATH=secret
Expand Down
4 changes: 2 additions & 2 deletions agent-manager-service/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ OAPI_CODEGEN := go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen@
.PHONY: gen-oc-client
gen-oc-client: ## Generate OpenChoreo API client from upstream OpenAPI spec.
@echo "Generating OpenChoreo client from upstream spec"
@curl -sL "https://raw.githubusercontent.com/openchoreo/openchoreo/v1.0.1/openapi/openchoreo-api.yaml" -o /tmp/openchoreo-api.yaml
@curl -sL "https://raw.githubusercontent.com/openchoreo/openchoreo/v1.1.1/openapi/openchoreo-api.yaml" -o /tmp/openchoreo-api.yaml
@$(OAPI_CODEGEN) -config clients/openchoreosvc/gen/oapi-codegen.yaml /tmp/openchoreo-api.yaml
@$(OAPI_CODEGEN) -config clients/openchoreosvc/gen/oapi-codegen-client.yaml /tmp/openchoreo-api.yaml
@rm /tmp/openchoreo-api.yaml
Expand All @@ -87,7 +87,7 @@ gen-oc-client: ## Generate OpenChoreo API client from upstream OpenAPI spec.
.PHONY: gen-observer-client
gen-observer-client: ## Generate Observer API client from upstream OpenAPI spec.
@echo "Generating Observer client from upstream spec"
@curl -sL "https://raw.githubusercontent.com/openchoreo/openchoreo/v1.0.1/openapi/observer-api.yaml" -o /tmp/observer-api.yaml
@curl -sL "https://raw.githubusercontent.com/openchoreo/openchoreo/v1.1.1/openapi/observer-api.yaml" -o /tmp/observer-api.yaml
@$(OAPI_CODEGEN) -config clients/observabilitysvc/gen/oapi-codegen.yaml /tmp/observer-api.yaml
@$(OAPI_CODEGEN) -config clients/observabilitysvc/gen/oapi-codegen-client.yaml /tmp/observer-api.yaml
@rm /tmp/observer-api.yaml
Expand Down
2 changes: 1 addition & 1 deletion agent-manager-service/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ type Options struct {
// The authProvider parameter allows different deployments to inject their own
// authentication mechanism (e.g., OAuth2 for open-source, workload identity for cloud).
// The secretProvider parameter allows different deployments to inject their own
// secret management backend (e.g., OpenBao for open-source, cloud-specific for cloud).
// secret management backend (e.g., the OpenChoreo secret API for open-source, cloud-specific for cloud).
func Run(authProvider occlient.AuthProvider, secretProvider secretmanagersvc.Provider, opts Options) {
cfg := config.GetConfig()

Expand Down
Loading
Loading