Call %whatis as a real hook function, remove $&whatis, and call %run to run binaries#241
Open
jpco wants to merge 3 commits intowryun:masterfrom
Open
Call %whatis as a real hook function, remove $&whatis, and call %run to run binaries#241jpco wants to merge 3 commits intowryun:masterfrom
%whatis as a real hook function, remove $&whatis, and call %run to run binaries#241jpco wants to merge 3 commits intowryun:masterfrom
Conversation
The core eval() code now looks for a function and then immediately falls back to calling %whatis, which takes care of any logic around binary searching and wrapping calls to binaries in %run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension to #90 and fixes #80.
This PR keeps resolution of functions within eval.c, but for anything else, it calls out to the function
%whatiswith the term it is looking up as well as the function name if applicable. Whatever%whatisreturns, es then attempts to evaluate.%whatisis simply defined as%whatisdoes a redundant function lookup for the sake of users callingwhatisor%whatis, but then looks for a binary and, if it finds one, returns a%runinvocation with the binary as an argument. As in #90,$&runis the only part of the shell actually responsible for invoking binary child processes.I think this is all surprisingly tidy. It makes both
%whatisand%runwork as hook functions like they both have always seemed like they should, it works fine with lexical functions without weirdness like$&keeplexicalbinding, and it's even some 20 fewer lines of code compared to the current behavior.