Skip to content

test(ci): appease staticcheck nil guards#154

Open
jonathanhaaswriter wants to merge 5 commits intomainfrom
fix/ci-staticcheck-tests
Open

test(ci): appease staticcheck nil guards#154
jonathanhaaswriter wants to merge 5 commits intomainfrom
fix/ci-staticcheck-tests

Conversation

@jonathanhaaswriter
Copy link
Copy Markdown
Collaborator

Summary

  • add explicit returns after nil-guard test failures that staticcheck cannot prove terminate execution
  • quiet the current SA5011 false positives across actionengine and API tests
  • unblock lint on the live-graph and store-backed follow-up PRs

Testing

  • go test ./internal/actionengine ./internal/api -count=1
  • python3 ./scripts/devex.py run --mode changed --base-ref writer/main

@jonathanhaaswriter jonathanhaaswriter force-pushed the fix/ci-staticcheck-tests branch from a5213d8 to 5bc292d Compare March 25, 2026 15:28
@jonathanhaaswriter
Copy link
Copy Markdown
Collaborator Author

Re-reviewed the current diff and I don't have any additional actionable findings right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant