fix(app): allow nlq previews without graph#149
Open
jonathanhaaswriter wants to merge 3 commits intofeat/graph-store-read-foundationfrom
Open
fix(app): allow nlq previews without graph#149jonathanhaaswriter wants to merge 3 commits intofeat/graph-store-read-foundationfrom
jonathanhaaswriter wants to merge 3 commits intofeat/graph-store-read-foundationfrom
Conversation
b271a42 to
f80edf0
Compare
89b2b6b to
6be0cac
Compare
Collaborator
Author
|
Re-reviewed the current diff and I don't have any additional actionable findings right now. |
Collaborator
Author
|
I think the tenant fail-closed contract regressed here. Once the configured Spanner store advertises tenant read scope, Can we add the same tenant-presence check (or a Spanner equivalent) before returning the scoped store? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cerebro.nl_querypreview-only requests to translate questions without requiring a readable security graphValidation
Stack
Base branch:
feat/graph-store-read-foundation