Skip to content

add local variabls for TKE and EL in Shinhong PBL - #2376

Open
Songyou184 wants to merge 1 commit into
wrf-model:release-v4.8.1from
Songyou184:SHPBL2026
Open

add local variabls for TKE and EL in Shinhong PBL#2376
Songyou184 wants to merge 1 commit into
wrf-model:release-v4.8.1from
Songyou184:SHPBL2026

Conversation

@Songyou184

Copy link
Copy Markdown
Contributor
modified:   module_bl_shinhong.F

Allocate the local variables

TYPE: Bug fix

KEYWORDS:

DESCRIPTION OF CHANGES:
Problem:
TKE valeus are unrealistic in tke diagnostics

Solution:
The 3D TKE and EL are allocated in module_bl_shinhong.F

ISSUE: For use when this PR closes an issue.
Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

@Songyou184
Songyou184 requested a review from a team as a code owner August 12, 2026 19:56
@weiwangncar
weiwangncar changed the base branch from master to release-v4.8.1 August 12, 2026 23:02
@weiwangncar

Copy link
Copy Markdown
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants