Skip to content

Bug fix in WDM7 - #2366

Open
Songyou184 wants to merge 3 commits into
wrf-model:release-v4.8.1from
Songyou184:WDM7
Open

Bug fix in WDM7#2366
Songyou184 wants to merge 3 commits into
wrf-model:release-v4.8.1from
Songyou184:WDM7

Conversation

@Songyou184

Copy link
Copy Markdown
Contributor

Purpose : Bug fix in WDM7 in computing sedimentation and hail physics

TYPE: Bug fix

KEYWORDS: WDM7, Sedimentation, Hail

SOURCE: Songyou Hong

DESCRIPTION OF CHANGES:
Problem:
Sedimentation of raindrop in WDM7 does not check the mass conservation
Dry growth of hail needs to be updated

Solution:
Sedimentation of rain checks the mass conservation
Dry growth of hail waits for the wet growth of hail

LIST OF MODIFIED FILES: module_mp_wdm7.F

TESTS CONDUCTED:

  1. It was tested by Hong for 2d-squall2d and results are physicall robust
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

@Songyou184
Songyou184 requested a review from a team as a code owner July 13, 2026 22:51
@weiwangncar

Copy link
Copy Markdown
Collaborator

Regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@dudhia

dudhia commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

This should be targeted for develop unless we have a 4.8.1 branch now.

@weiwangncar
weiwangncar changed the base branch from master to develop July 27, 2026 17:28
@weiwangncar
weiwangncar changed the base branch from develop to release-v4.8.1 July 27, 2026 19:36

@dudhia dudhia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the final change in WDM7?

@Songyou184

Songyou184 commented Aug 7, 2026 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants