Bug fix in WDM7 - #2366
Open
Songyou184 wants to merge 3 commits into
Open
Conversation
Collaborator
|
Regression test results: |
Collaborator
|
This should be targeted for develop unless we have a 4.8.1 branch now. |
dudhia
approved these changes
Aug 4, 2026
dudhia
left a comment
Collaborator
There was a problem hiding this comment.
is this the final change in WDM7?
Contributor
Author
|
yes. it is the final...
…On Tue, Aug 4, 2026 at 1:23 PM dudhia ***@***.***> wrote:
***@***.**** approved this pull request.
is this the final change in WDM7?
—
Reply to this email directly, view it on GitHub
<#2366?email_source=notifications&email_token=AVR3U6UPGT66RSHUNSYA6FT5IIZ3LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBVHAYTMMJSHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4858161299>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVR3U6WCSRR63OOISNBPJMT5IIZ3LAVCNFSNUABEKJSXA33TNF2G64TZHM3DKOBVGIYDMOJ3JFZXG5LFHM2DQNZYGI4TCMBXGKQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AVR3U6VL3LXK6IYLQ7CEMVD5IIZ3LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBVHAYTMMJSHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AVR3U6QT7M5AA4D7H2YIZ5T5IIZ3LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBVHAYTMMJSHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
smileMchen
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose : Bug fix in WDM7 in computing sedimentation and hail physics
TYPE: Bug fix
KEYWORDS: WDM7, Sedimentation, Hail
SOURCE: Songyou Hong
DESCRIPTION OF CHANGES:
Problem:
Sedimentation of raindrop in WDM7 does not check the mass conservation
Dry growth of hail needs to be updated
Solution:
Sedimentation of rain checks the mass conservation
Dry growth of hail waits for the wet growth of hail
LIST OF MODIFIED FILES: module_mp_wdm7.F
TESTS CONDUCTED:
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.