Trim whitespace from --exclude entries in core and plugin verify-checksums#156
Closed
alaminfirdows wants to merge 2 commits into
Closed
Trim whitespace from --exclude entries in core and plugin verify-checksums#156alaminfirdows wants to merge 2 commits into
alaminfirdows wants to merge 2 commits into
Conversation
Both core and plugin verify-checksums used explode(',', $exclude) without
trimming, causing entries like ' b' in 'a, b' to silently not match.
Wrap with array_map('trim', ...) so 'a, b' and 'a,b' behave identically.
Covers the case where users pass comma-separated values with surrounding spaces (e.g. 'a, b') which should behave identically to 'a,b'.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
explode( ',', $exclude )in bothChecksum_Core_CommandandChecksum_Plugin_Commandproduces entries with leading/trailing spaces when the user writes a comma-separated list with spaces (e.g."a, b, c").in_array( ..., true )strict comparison means' b' !== 'b', so those entries silently match nothing.array_map( 'trim', ... )so"a, b"and"a,b"behave identically.Changes
src/Checksum_Core_Command.phpline 129:array_map( 'trim', explode( ',', $exclude ) )src/Checksum_Plugin_Command.phpline 106:array_map( 'trim', explode( ',', $exclude ) )features/checksum-core.feature: new scenario covering spaced exclude listfeatures/checksum-plugin.feature: new scenario covering leading-space exclude entryTesting
Functional tests added in both
.featurefiles covering the whitespace case.Fixes:
--excludedoes not trim whitespace, so space-separated entries are silently not excluded.