Add custom field orderin with field_dynamic#670
Draft
zimakki wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, thank you for all your efforts and for looking into this.
What this does
This adds support for ordering by custom fields through a new
field_dynamicoption. It’s a smaller, ordering-only version of the work discussed in #511 and drafted in #662.I’ve kept the scope fairly narrow: filtering still uses
filter, and custom fields remain unsupported for cursor pagination (#623). Named bindings continue to work, and runtimeextra_optsare merged with the field’s configured options. If the same key appears in both, the configured value wins.Docs and regression tests are included as well.
Verification
mix format --check-formattedmix credo --strictmix compile --warnings-as-errorsmix test --warnings-as-errors— 360 passedmix test.postgres --warnings-as-errors— 197 passedmix dialyzer— 0 errorsI also tested it in the downstream app that prompted this work. It has 27 calculated sortable fields, and both its focused ordering tests and full test suite pass with this branch.
I’m happy to adjust the API shape, naming, or anything else to fit Flop better.