feat: support teleport deployment and stage image in x-deploy#1138
feat: support teleport deployment and stage image in x-deploy#1138AlexKaravaev wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 483c702493
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| target.contains('.') || target.contains(':') |
There was a problem hiding this comment.
looks_like_ssh_target only returns true when the target contains . or :, so valid SSH hostnames like localhost, orb-dev, or /etc/hosts aliases are misclassified as Teleport targets. In those cases resolve_remote_target calls tsh ls -v and fails to resolve instead of using SSH, which is a regression from the previous behavior where deploy always used SSH for the provided host string.
Useful? React with 👍 / 👎.
2 participants
This allows to: